diff options
| author | Vic Yang <victoryang@chromium.org> | 2014-05-19 15:03:27 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-21 20:32:17 +0000 |
| commit | ffac23c0ea1bd4ff4568f5bd709a98f912b833a7 (patch) | |
| tree | 362dd0ba205731aa07be97dd35b44b237799b23b /driver/charger/bq24192.c | |
| parent | 478361de694b1fb45abf3c38dafbbf7fd1aa5f71 (diff) | |
| download | chrome-ec-ffac23c0ea1bd4ff4568f5bd709a98f912b833a7.tar.gz | |
Add cprints() and ccprints()
Our code base contains a lot of debug messages in this pattern:
CPRINTF("[%T xxx]\n") or ccprintf("[%T xxx]\n")
The strings are taking up spaces in the EC binaries, so let's refactor
this by adding cprints() and ccprints().
cprints() is just like cprintf(), except that it adds the brackets
and the timestamp. ccprints() is equivalent to cprints(CC_CONSOLE, ...)
This saves us hundreds of bytes in EC binaries.
BUG=chromium:374575
TEST=Build and check flash size
BRANCH=None
Change-Id: Ifafe8dc1b80e698b28ed42b70518c7917b49ee51
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/200490
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'driver/charger/bq24192.c')
| -rw-r--r-- | driver/charger/bq24192.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/driver/charger/bq24192.c b/driver/charger/bq24192.c index c58bb0b006..099a44c815 100644 --- a/driver/charger/bq24192.c +++ b/driver/charger/bq24192.c @@ -17,7 +17,7 @@ /* Console output macros */ #define CPUTS(outstr) cputs(CC_CHARGER, outstr) -#define CPRINTF(format, args...) cprintf(CC_CHARGER, format, ## args) +#define CPRINTS(format, args...) cprints(CC_CHARGER, format, ## args) /* Charger information */ static const struct charger_info bq24192_charger_info = { @@ -217,7 +217,7 @@ static void bq24192_init(void) int val; if (charger_device_id(&val) || val != BQ24192_DEVICE_ID) { - CPRINTF("[%T BQ24192 incorrent ID: 0x%02x]\n", val); + CPRINTF("BQ24192 incorrent ID: 0x%02x", val); return; } @@ -241,7 +241,7 @@ static void bq24192_init(void) if (bq24192_watchdog_reset()) return; - CPRINTF("[%T BQ24192 initialized]\n"); + CPRINTF("BQ24192 initialized"); } DECLARE_HOOK(HOOK_INIT, bq24192_init, HOOK_PRIO_LAST); |