diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /driver/charger/bq24738.h | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'driver/charger/bq24738.h')
| -rw-r--r-- | driver/charger/bq24738.h | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/driver/charger/bq24738.h b/driver/charger/bq24738.h index a40a9e193f..194a2941c0 100644 --- a/driver/charger/bq24738.h +++ b/driver/charger/bq24738.h @@ -15,43 +15,43 @@ #define BQ24738_DEVICE_ID 0xff /* ChargeOption 0x12 */ -#define OPTION_CHARGE_INHIBIT (1 << 0) -#define OPTION_ACOC_THRESHOLD (1 << 1) -#define OPTION_BOOST_MODE_STATE (1 << 2) -#define OPTION_BOOST_MODE_ENABLE (1 << 3) -#define OPTION_ACDET_STATE (1 << 4) -#define OPTION_IOUT_SELECTION (1 << 5) -#define OPTION_LEARN_ENABLE (1 << 6) -#define OPTION_IFAULT_LOW_THRESHOLD (1 << 7) -#define OPTION_IFAULT_HI_ENABLE (1 << 8) -#define OPTION_EMI_FREQ_ENABLE (1 << 9) -#define OPTION_EMI_FREQ_ADJ (1 << 10) +#define OPTION_CHARGE_INHIBIT BIT(0) +#define OPTION_ACOC_THRESHOLD BIT(1) +#define OPTION_BOOST_MODE_STATE BIT(2) +#define OPTION_BOOST_MODE_ENABLE BIT(3) +#define OPTION_ACDET_STATE BIT(4) +#define OPTION_IOUT_SELECTION BIT(5) +#define OPTION_LEARN_ENABLE BIT(6) +#define OPTION_IFAULT_LOW_THRESHOLD BIT(7) +#define OPTION_IFAULT_HI_ENABLE BIT(8) +#define OPTION_EMI_FREQ_ENABLE BIT(9) +#define OPTION_EMI_FREQ_ADJ BIT(10) #define OPTION_BAT_DEPLETION_THRESHOLD (3 << 11) #define OPTION_WATCHDOG_TIMER (3 << 13) -#define OPTION_ACPRES_DEGLITCH_TIME (1 << 15) +#define OPTION_ACPRES_DEGLITCH_TIME BIT(15) /* OPTION_ACOC_THRESHOLD */ #define ACOC_THRESHOLD_DISABLE (0 << 1) -#define ACOC_THRESHOLD_133X (1 << 1) +#define ACOC_THRESHOLD_133X BIT(1) /* OPTION_IFAULT_LOW_THRESHOLD */ #define IFAULT_LOW_135MV_DEFAULT (0 << 7) -#define IFAULT_LOW_230MV (1 << 7) +#define IFAULT_LOW_230MV BIT(7) /* OPTION_BAT_DEPLETION_THRESHOLD */ #define FALLING_THRESHOLD_5919 (0 << 11) -#define FALLING_THRESHOLD_6265 (1 << 11) +#define FALLING_THRESHOLD_6265 BIT(11) #define FALLING_THRESHOLD_6655 (2 << 11) #define FALLING_THRESHOLD_7097_DEFAULT (3 << 11) /* OPTION_WATCHDOG_TIMER */ #define CHARGE_WATCHDOG_DISABLE (0 << 13) -#define CHARGE_WATCHDOG_44SEC (1 << 13) +#define CHARGE_WATCHDOG_44SEC BIT(13) #define CHARGE_WATCHDOG_88SEC (2 << 13) #define CHARGE_WATCHDOG_175SEC_DEFAULT (3 << 13) /* OPTION_ACPRES_DEGLITCH_TIME */ #define ACPRES_DEGLITCH_150MS (0 << 15) -#define ACPRES_DEGLITCH_1300MS_DEFAULT (1 << 15) +#define ACPRES_DEGLITCH_1300MS_DEFAULT BIT(15) #endif /* __CROS_EC_BQ24738_H */ |