diff options
| author | Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com> | 2021-10-07 22:34:46 +0530 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-10-20 23:01:01 +0000 |
| commit | b09158a9071226c243702d33919dd3132a6edfb2 (patch) | |
| tree | ea64ffcdabb8b658d57a206783877ec9d32b31e8 /driver/charger/isl9241.c | |
| parent | 9cb708d986a3c693ac97b8301f492497a89e4f13 (diff) | |
| download | chrome-ec-b09158a9071226c243702d33919dd3132a6edfb2.tar.gz | |
cleanup: charger: consolidate charger_dump console commands
Console command "charger_dump" is defined in multiple charger
driver files, hence, build fails when more than one charger chip
drivers are enabled for a platform.
To avoid this "charger_dump" console command is defined in
a common file, and this command handler invokes platform specific
charger dump register api.
BRANCH=none
BUG=none
TEST=Verified 'charger dump' command on brya
Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com>
Change-Id: Ic542af90b47880e90073c529f9183abc6a3f5af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3211760
Commit-Queue: caveh jalali <caveh@chromium.org>
Reviewed-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'driver/charger/isl9241.c')
| -rw-r--r-- | driver/charger/isl9241.c | 19 |
1 files changed, 4 insertions, 15 deletions
diff --git a/driver/charger/isl9241.c b/driver/charger/isl9241.c index d53c8998ba..45073e1897 100644 --- a/driver/charger/isl9241.c +++ b/driver/charger/isl9241.c @@ -546,17 +546,8 @@ static void dump_reg_range(int chgnum, int low, int high) } } -static int command_isl9241_dump(int argc, char **argv) +static void command_isl9241_dump(int chgnum) { - char *e; - int chgnum = 0; - - if (argc >= 2) { - chgnum = strtoi(argv[1], &e, 10); - if (*e) - return EC_ERROR_PARAM1; - } - dump_reg_range(chgnum, 0x14, 0x15); dump_reg_range(chgnum, 0x38, 0x40); dump_reg_range(chgnum, 0x43, 0x43); @@ -564,12 +555,7 @@ static int command_isl9241_dump(int argc, char **argv) dump_reg_range(chgnum, 0x80, 0x87); dump_reg_range(chgnum, 0x90, 0x91); dump_reg_range(chgnum, 0xFE, 0xFF); - - return EC_SUCCESS; } -DECLARE_CONSOLE_COMMAND(charger_dump, command_isl9241_dump, - "charger_dump <chgnum>", - "Dumps ISL9241 registers"); #endif /* CONFIG_CMD_CHARGER_DUMP */ const struct charger_drv isl9241_drv = { @@ -596,4 +582,7 @@ const struct charger_drv isl9241_drv = { .ramp_is_detected = &isl9241_ramp_is_detected, .ramp_get_current_limit = &isl9241_ramp_get_current_limit, #endif +#ifdef CONFIG_CMD_CHARGER_DUMP + .dump_registers = &command_isl9241_dump, +#endif }; |