diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /driver/gyro_l3gd20h.c | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'driver/gyro_l3gd20h.c')
| -rw-r--r-- | driver/gyro_l3gd20h.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/driver/gyro_l3gd20h.c b/driver/gyro_l3gd20h.c index 2afe948f27..d7d3663ab2 100644 --- a/driver/gyro_l3gd20h.c +++ b/driver/gyro_l3gd20h.c @@ -75,7 +75,7 @@ static inline int get_ctrl_reg(enum motionsensor_type type) static inline int get_xyz_reg(enum motionsensor_type type) { - return L3GD20_OUT_X_L | (1 << 7); + return L3GD20_OUT_X_L | BIT(7); } /** @@ -240,8 +240,8 @@ static int set_data_rate(const struct motion_sensor_t *s, if (ret != EC_SUCCESS) goto gyro_cleanup; - val |= (1 << 4); /* high-pass filter enabled */ - val |= (1 << 0); /* data in data reg are high-pass filtered */ + val |= BIT(4); /* high-pass filter enabled */ + val |= BIT(0); /* data in data reg are high-pass filtered */ ret = raw_write8(s->port, s->addr, L3GD20_CTRL_REG5, val); if (ret != EC_SUCCESS) goto gyro_cleanup; |