diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /driver/led/lm3630a.h | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'driver/led/lm3630a.h')
| -rw-r--r-- | driver/led/lm3630a.h | 36 |
1 files changed, 18 insertions, 18 deletions
diff --git a/driver/led/lm3630a.h b/driver/led/lm3630a.h index 38fc52e111..d43304b66e 100644 --- a/driver/led/lm3630a.h +++ b/driver/led/lm3630a.h @@ -27,37 +27,37 @@ #define LM3630A_REG_FILTER_STRENGTH 0x50 /* Control register bits */ -#define LM3630A_CTRL_BIT_SLEEP_CMD (1 << 7) -#define LM3630A_CTRL_BIT_SLEEP_STAT (1 << 6) -#define LM3630A_CTRL_BIT_LINEAR_A (1 << 4) -#define LM3630A_CTRL_BIT_LINEAR_B (1 << 3) -#define LM3630A_CTRL_BIT_LED_EN_A (1 << 2) -#define LM3630A_CTRL_BIT_LED_EN_B (1 << 1) -#define LM3630A_CTRL_BIT_LED2_ON_A (1 << 0) +#define LM3630A_CTRL_BIT_SLEEP_CMD BIT(7) +#define LM3630A_CTRL_BIT_SLEEP_STAT BIT(6) +#define LM3630A_CTRL_BIT_LINEAR_A BIT(4) +#define LM3630A_CTRL_BIT_LINEAR_B BIT(3) +#define LM3630A_CTRL_BIT_LED_EN_A BIT(2) +#define LM3630A_CTRL_BIT_LED_EN_B BIT(1) +#define LM3630A_CTRL_BIT_LED2_ON_A BIT(0) /* Config register bits */ -#define LM3630A_CFG_BIT_FB_EN_B (1 << 4) -#define LM3630A_CFG_BIT_FB_EN_A (1 << 3) -#define LM3630A_CFG_BIT_PWM_LOW (1 << 2) -#define LM3630A_CFG_BIT_PWM_EN_B (1 << 1) -#define LM3630A_CFG_BIT_PWM_EN_A (1 << 0) +#define LM3630A_CFG_BIT_FB_EN_B BIT(4) +#define LM3630A_CFG_BIT_FB_EN_A BIT(3) +#define LM3630A_CFG_BIT_PWM_LOW BIT(2) +#define LM3630A_CFG_BIT_PWM_EN_B BIT(1) +#define LM3630A_CFG_BIT_PWM_EN_A BIT(0) /* Boost control register bits */ #define LM3630A_BOOST_OVP_16V (0 << 5) -#define LM3630A_BOOST_OVP_24V (1 << 5) +#define LM3630A_BOOST_OVP_24V BIT(5) #define LM3630A_BOOST_OVP_32V (2 << 5) #define LM3630A_BOOST_OVP_40V (3 << 5) #define LM3630A_BOOST_OCP_600MA (0 << 3) -#define LM3630A_BOOST_OCP_800MA (1 << 3) +#define LM3630A_BOOST_OCP_800MA BIT(3) #define LM3630A_BOOST_OCP_1000MA (2 << 3) #define LM3630A_BOOST_OCP_1200MA (3 << 3) -#define LM3630A_BOOST_SLOW_START (1 << 2) +#define LM3630A_BOOST_SLOW_START BIT(2) #define LM3630A_SHIFT_500KHZ (0 << 1) /* FMODE=0 */ -#define LM3630A_SHIFT_560KHZ (1 << 1) /* FMODE=0 */ +#define LM3630A_SHIFT_560KHZ BIT(1) /* FMODE=0 */ #define LM3630A_SHIFT_1000KHZ (0 << 1) /* FMODE=1 */ -#define LM3630A_SHIFT_1120KHZ (1 << 1) /* FMODE=1 */ +#define LM3630A_SHIFT_1120KHZ BIT(1) /* FMODE=1 */ #define LM3630A_FMODE_500KHZ (0 << 0) -#define LM3630A_FMODE_1000KHZ (1 << 0) +#define LM3630A_FMODE_1000KHZ BIT(0) /* Power on and initialize LM3630A. */ int lm3630a_poweron(void); |