summaryrefslogtreecommitdiff
path: root/driver/mag_bmm150.c
diff options
context:
space:
mode:
authorYilun Lin <yllin@google.com>2018-09-08 00:06:09 +0800
committerchrome-bot <chrome-bot@chromium.org>2018-09-13 06:13:47 -0700
commitc4a842a78c778e7c15cd3f78ae354e4d21a85ae9 (patch)
tree6668b4fd3911769f0011b5b17512d66923eea5fc /driver/mag_bmm150.c
parente6344f8560bad936573be75f6b2810373c2cdb01 (diff)
downloadchrome-ec-c4a842a78c778e7c15cd3f78ae354e4d21a85ae9.tar.gz
type: Rename vector_3_t to intv3_t.
Naming of many vector types and matrix types are not clear enough. For example, we have: vector_3_t, which is a vector of three int. vec3_t, which is a vector of three float. size4_t, which is a vector of four size_t. mat33_t, which is a 3x3 matrix of float. matrix_3x3_t, which is a 3x3 matrix of fixed point. Besides, we have types like int8_t, uint16_t types. To clearly distinguished types, the CL propose to, For vector types, naming should be `$type + 'v' + $num + '_t'`: vector_3_t becomes intv3_t vec3_t becomes floatv3_t vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet) For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the matrix size: matrix_3x3_t becomes mat33_fp_t # fp: fixed point mat33_t becomes mat33_float_t TEST=make buildall -j BUG=b:114662791 Change-Id: I865aa3ecbab6cb97f8585a081a679adf00febe1d Signed-off-by: Yilun Lin <yllin@google.com> Reviewed-on: https://chromium-review.googlesource.com/1215442 Commit-Ready: Yilun Lin <yllin@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'driver/mag_bmm150.c')
-rw-r--r--driver/mag_bmm150.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/driver/mag_bmm150.c b/driver/mag_bmm150.c
index 014909b365..cb53641c00 100644
--- a/driver/mag_bmm150.c
+++ b/driver/mag_bmm150.c
@@ -140,8 +140,8 @@ int bmm150_init(const struct motion_sensor_t *s)
}
void bmm150_temp_compensate_xy(const struct motion_sensor_t *s,
- vector_3_t raw,
- vector_3_t comp,
+ intv3_t raw,
+ intv3_t comp,
int r)
{
int inter, axis;
@@ -179,8 +179,8 @@ void bmm150_temp_compensate_xy(const struct motion_sensor_t *s,
}
void bmm150_temp_compensate_z(const struct motion_sensor_t *s,
- vector_3_t raw,
- vector_3_t comp,
+ intv3_t raw,
+ intv3_t comp,
int r)
{
int dividend, divisor;
@@ -209,11 +209,11 @@ void bmm150_temp_compensate_z(const struct motion_sensor_t *s,
}
void bmm150_normalize(const struct motion_sensor_t *s,
- vector_3_t v,
+ intv3_t v,
uint8_t *data)
{
uint16_t r;
- vector_3_t raw;
+ intv3_t raw;
struct mag_cal_t *cal = BMM150_CAL(s);
/* X and Y are two's complement 13 bits vectors */
@@ -235,7 +235,7 @@ void bmm150_normalize(const struct motion_sensor_t *s,
}
int bmm150_set_offset(const struct motion_sensor_t *s,
- const vector_3_t offset)
+ const intv3_t offset)
{
struct mag_cal_t *cal = BMM150_CAL(s);
cal->bias[X] = offset[X];
@@ -245,7 +245,7 @@ int bmm150_set_offset(const struct motion_sensor_t *s,
}
int bmm150_get_offset(const struct motion_sensor_t *s,
- vector_3_t offset)
+ intv3_t offset)
{
struct mag_cal_t *cal = BMM150_CAL(s);
offset[X] = cal->bias[X];