summaryrefslogtreecommitdiff
path: root/driver/retimer/bb_retimer.c
diff options
context:
space:
mode:
authorJett Rink <jettrink@chromium.org>2020-01-10 11:48:43 -0700
committerCommit Bot <commit-bot@chromium.org>2020-01-29 19:52:45 +0000
commitf22bc063c93bf1245f872008116359f484cadf70 (patch)
tree4181b6ee0be5e732b986ac6b427aa4f2ce4e63dc /driver/retimer/bb_retimer.c
parent1e5b4a11489173de522836224951a47e9aef7c35 (diff)
downloadchrome-ec-f22bc063c93bf1245f872008116359f484cadf70.tar.gz
spi: keep HW SPI module enabled longer
When the HW SPI module is disabled (i.e. SPE bit is cleared), then the stm stops actively driving the SPI CLK signal and lets it float. This can cause spurious communication issues or guaranteed issues if there is a pullup on the CLK signal. Ensure that the CLK signal is being driven (low) for the duration of a USB SPI transaction at minimum. Driving the CLK signal low for the duration of the SPI transaction also seems to help with sporadic reliability issues on servo_micro Also add a flag that enables the SPI module to be enabled for the entire time the firmware wants to enable the SPI module opposed to needing both the firmware and the USB host to enabled the SPI module. BRANCH=servo BUG=b:145314772,b:144846350 TEST=with scope verify that SPI CLK line is help low as soon at the `enable_spi 1800` command is enter on C2D2 console and continues to stay low in between all USB SPI traffic from host. Change-Id: I9dbd6b3ebca8db6470d9ec70bae02ac8366d6c9e Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1995604 Reviewed-by: Brian Nemec <bnemec@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'driver/retimer/bb_retimer.c')
0 files changed, 0 insertions, 0 deletions