diff options
| author | Divya Sasidharan <divya.s.sasidharan@intel.com> | 2020-10-27 15:02:33 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-12-11 19:41:53 +0000 |
| commit | 69115e7b4c6e60df848442f1f1c113b630acdcac (patch) | |
| tree | 57da7667a83e1199214f496e8c0b4e2d4c5e6fbe /driver/retimer | |
| parent | 73ea2e6702c771b026934d1327796e1024d44438 (diff) | |
| download | chrome-ec-69115e7b4c6e60df848442f1f1c113b630acdcac.tar.gz | |
Revert "bb_retimer: Bypass safe mode configuration in retimer"
This reverts commit 14a10f746d2e4ae195a14fbcf9c0a2fb57d42239.
This was a workaround and is being removed for appropriate
solution to synchronize time in safe mode for retimer and
TCSS mux.
BUG=b:166300460
BRANCH=none
TEST=none
Change-Id: I6d997caca59942a0bd14a987737997b48a1ede4f
Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2504477
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Tanu Malhotra <tanu.malhotra@intel.com>
Diffstat (limited to 'driver/retimer')
| -rw-r--r-- | driver/retimer/bb_retimer.c | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/driver/retimer/bb_retimer.c b/driver/retimer/bb_retimer.c index ff37bdb9f9..d6200d521c 100644 --- a/driver/retimer/bb_retimer.c +++ b/driver/retimer/bb_retimer.c @@ -323,21 +323,7 @@ static int retimer_set_state(const struct usb_mux *me, mux_state_t mux_state) uint32_t set_retimer_con = 0; uint8_t dp_pin_mode; int port = me->usb_port; - /* - * TODO(b/161327513): Remove this once we have final fix for - * the Type-C MFD degradation issue. - * In alternate mode, mux changes states as USB->Safe->DP Alt Mode. - * As EC programs retimer into safe mode independent of virtual mux, - * the super speed lanes are terminated while IOM is in the process - * of establishing the super speed link, which causes a fallback to - * USB 2.0 enumeration through PCH. By removing the Safe mode in retimer - * Super Speed lanes are available to virtual mux and would not - * interrupt the enumeration process and then entering safe. - * From the protocol analyser traces the safe mode is still achieved - * with virtual mux Safe mode settings. - */ - if (mux_state & USB_PD_MUX_SAFE_MODE) - return 0; + /* * Bit 0: DATA_CONNECTION_PRESENT * 0 - No connection present |