diff options
| author | Diana Z <dzigterman@chromium.org> | 2021-10-18 15:27:01 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-12-02 23:09:27 +0000 |
| commit | 18f6c4d3b2a56635ce880788047083115637885c (patch) | |
| tree | c735046c4f418c6addfd2c6228252a81388f8b4f /driver/retimer | |
| parent | 5175aa6b6d38c1819e3820d889d8f02d7226fac1 (diff) | |
| download | chrome-ec-18f6c4d3b2a56635ce880788047083115637885c.tar.gz | |
USB MUX: Wait on ACK for HPD changes when required
In order to correctly sequence HPD sets with the AP, allow the HPD set
to wait on an ACK from the AP before proceeding.
BRANCH=None
BUG=b:202137658
TEST=on brya, validate retimer and virtual mux are kept in sync as
expected
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I368c3290b69d627829a70847876d7b47a8c36948
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3232293
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Diffstat (limited to 'driver/retimer')
| -rw-r--r-- | driver/retimer/bb_retimer.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/driver/retimer/bb_retimer.c b/driver/retimer/bb_retimer.c index bf3da60b32..627f61b3e6 100644 --- a/driver/retimer/bb_retimer.c +++ b/driver/retimer/bb_retimer.c @@ -472,10 +472,14 @@ static int retimer_set_state(const struct usb_mux *me, mux_state_t mux_state, set_retimer_con); } -void bb_retimer_hpd_update(const struct usb_mux *me, mux_state_t mux_state) +void bb_retimer_hpd_update(const struct usb_mux *me, mux_state_t mux_state, + bool *ack_required) { uint32_t retimer_con_reg = 0; + /* This driver does not use host command ACKs */ + *ack_required = false; + if (bb_retimer_read(me, BB_RETIMER_REG_CONNECTION_STATE, &retimer_con_reg) != EC_SUCCESS) return; |