diff options
| author | Caveh Jalali <caveh@chromium.org> | 2021-06-11 18:21:26 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-06-15 20:49:56 +0000 |
| commit | a037fe1ac20c14c8addd0a186efda142578c081e (patch) | |
| tree | 05d96fdf630fda852a8f8aa4c553289ae5da9f8c /driver/retimer | |
| parent | 00059471517c089a5e356f2859b691969535b5f6 (diff) | |
| download | chrome-ec-a037fe1ac20c14c8addd0a186efda142578c081e.tar.gz | |
bb_retimer: Explicitly check EC status codes
This replaces inverted boolean logic with explicit comparison with
EC_SUCCESS for improved readability.
BRANCH=none
BUG=b:181743576,b:188826559
TEST=compare_builds.sh matches
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Change-Id: Id5aaa167b2e9071e5757f561d788da49af03f9d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2962214
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
Diffstat (limited to 'driver/retimer')
| -rw-r--r-- | driver/retimer/bb_retimer.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/driver/retimer/bb_retimer.c b/driver/retimer/bb_retimer.c index 2d23827f91..2f98b4b185 100644 --- a/driver/retimer/bb_retimer.c +++ b/driver/retimer/bb_retimer.c @@ -62,7 +62,7 @@ static int bb_retimer_read(const struct usb_mux *me, rv = i2c_xfer(me->i2c_port, me->i2c_addr_flags, &offset, 1, buf, BB_RETIMER_READ_SIZE); - if (!rv) + if (rv == EC_SUCCESS) break; if (++retry >= BB_RETIMER_I2C_RETRY) { @@ -110,7 +110,7 @@ static int bb_retimer_write(const struct usb_mux *me, rv = i2c_xfer(me->i2c_port, me->i2c_addr_flags, buf, BB_RETIMER_WRITE_SIZE, NULL, 0); - if (!rv) + if (rv == EC_SUCCESS) break; if (++retry >= BB_RETIMER_I2C_RETRY) { @@ -496,14 +496,14 @@ static int retimer_init(const struct usb_mux *me) return rv; rv = bb_retimer_read(me, BB_RETIMER_REG_VENDOR_ID, &data); - if (rv) + if (rv != EC_SUCCESS) return rv; if ((data != BB_RETIMER_VENDOR_ID_1) && data != BB_RETIMER_VENDOR_ID_2) return EC_ERROR_INVAL; rv = bb_retimer_read(me, BB_RETIMER_REG_DEVICE_ID, &data); - if (rv) + if (rv != EC_SUCCESS) return rv; if (data != BB_RETIMER_DEVICE_ID) return EC_ERROR_INVAL; |