diff options
| author | Denis Brockus <dbrockus@chromium.org> | 2020-02-14 07:53:11 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-15 02:12:59 +0000 |
| commit | 4588844d403aad4b9c6bd0732ad6423646ce7a51 (patch) | |
| tree | b14fc6579eb9633dbd3b2110e791d139c8fa353f /driver/tcpm/anx74xx.c | |
| parent | 139e94729bc55c6dbf838d1136c04b7ce711c48f (diff) | |
| download | chrome-ec-4588844d403aad4b9c6bd0732ad6423646ce7a51.tar.gz | |
usbc: remove tri-state polarity
TCPCIr2 had an issue with setting CC coming out of DRP
that if the polarity was not retained that the connection
dropped back to OPEN. Unfortunately this change broke
many of the other TCPCI implementations. I am working
on a different method of dealing with coming out of DRP
and this is no longer needed.
BUG=none
BRANCH=none
TEST=verify USB-C is working
Change-Id: Ifa8f26d417df2f5d5f41a23fbf7e6f9129031e94
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2056968
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'driver/tcpm/anx74xx.c')
| -rw-r--r-- | driver/tcpm/anx74xx.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/driver/tcpm/anx74xx.c b/driver/tcpm/anx74xx.c index 7cdde05410..0e9635e6b1 100644 --- a/driver/tcpm/anx74xx.c +++ b/driver/tcpm/anx74xx.c @@ -765,16 +765,6 @@ static int anx74xx_tcpm_set_polarity(int port, enum tcpc_cc_polarity polarity) { int reg, mux_state, rv = EC_SUCCESS; - /* - * TCPCI sets the CC lines based on polarity. If it is set to - * no connection then both CC lines are driven, otherwise only - * one is driven. This driver does not appear to do this. If - * that changes, this would be the location you would want to - * adjust the CC lines for the current polarity - */ - if (polarity == POLARITY_NONE) - return EC_SUCCESS; - rv |= tcpc_read(port, ANX74XX_REG_CC_SOFTWARE_CTRL, ®); if (polarity_rm_dts(polarity)) /* Inform ANX to use CC2 */ reg &= ~ANX74XX_REG_SELECT_CC1; |