diff options
| author | Jett Rink <jettrink@chromium.org> | 2018-09-26 10:04:56 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-28 13:34:33 -0700 |
| commit | 2c6a5494f5a996be96bd07f3dd5c4d7edb4be596 (patch) | |
| tree | 4222e55edc1873f5a86877e8d57fa2d97690815c /driver/tcpm/anx74xx.c | |
| parent | 47cfe9cfe62427d24babddd1f8e9dae88b1cb7d8 (diff) | |
| download | chrome-ec-2c6a5494f5a996be96bd07f3dd5c4d7edb4be596.tar.gz | |
anx3429: mark that version 1.6V is required
Due to SOP' false detection issues, anyone using ANX3429 should upgrade
the firmware to version 1.6
This new field will be used by factory/automated tests to ensure new
boards (and existing board that cherry pick these changes) remember to
upgrade the TCPC FW thus avoiding discovering the same bugs in each
project.
BRANCH=none
BUG=b:64752060,b:116255749
TEST=tested ps8751 path with is the same as ANX. I don't have a device
with ANX3429 right now.
Change-Id: Id4df192aca30f82baee3021189aef72a62deee4e
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1246266
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Diffstat (limited to 'driver/tcpm/anx74xx.c')
| -rw-r--r-- | driver/tcpm/anx74xx.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/driver/tcpm/anx74xx.c b/driver/tcpm/anx74xx.c index 79af4c054b..fd114f7385 100644 --- a/driver/tcpm/anx74xx.c +++ b/driver/tcpm/anx74xx.c @@ -1059,6 +1059,15 @@ static int anx74xx_get_chip_info(int port, int renew, (*chip_info)->fw_version_number = val; +#ifdef CONFIG_USB_PD_TCPM_ANX3429 + /* + * Min firmware version of ANX3429 to ensure that false SOP' detection + * doesn't occur for e-marked cables. See b/116255749#comment8 and + * b/64752060#comment11 + */ + (*chip_info)->min_req_fw_version_number = 0x16; +#endif + return rv; } |