summaryrefslogtreecommitdiff
path: root/driver/tcpm/tcpci.c
diff options
context:
space:
mode:
authorEric Herrmann <eherrmann@chromium.org>2020-07-09 15:26:24 -0700
committerCommit Bot <commit-bot@chromium.org>2020-07-14 01:23:14 +0000
commit2c013315d4b8af170257bb26b794dab382fa3118 (patch)
tree153d7751a29788c27191cc9227b71cf3626fe9a3 /driver/tcpm/tcpci.c
parent8836c705860087bf2b80564f75050689a0159a04 (diff)
downloadchrome-ec-2c013315d4b8af170257bb26b794dab382fa3118.tar.gz
TCPCI: Update alert mask to allow FRS alerts
The TCPCI unmask init wasn't umasking the extended alerts. They need to be unmasked for FRS detection. FRS is only supported as part of the TCPCI spec Rev 2.0. In rev 1.0, the relevant registers are reserved so Rev 1 TCPCs should ignore any writes. BUG=b:148144711 TEST=make buildall BRANCH=none Change-Id: If3164dba508df5a8fe686ebc1130ac72293fb306 Signed-off-by: Eric Herrmann <eherrmann@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2290841 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Diffstat (limited to 'driver/tcpm/tcpci.c')
-rw-r--r--driver/tcpm/tcpci.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/driver/tcpm/tcpci.c b/driver/tcpm/tcpci.c
index 651160f531..653d29e437 100644
--- a/driver/tcpm/tcpci.c
+++ b/driver/tcpm/tcpci.c
@@ -315,6 +315,9 @@ static int init_alert_mask(int port)
if (TCPC_FLAGS_VSAFE0V(tcpc_config[port].flags))
mask |= TCPC_REG_ALERT_EXT_STATUS;
+ if (IS_ENABLED(CONFIG_USB_PD_FRS_TCPC))
+ mask |= TCPC_REG_ALERT_ALERT_EXT;
+
/* Set the alert mask in TCPC */
rv = tcpc_write16(port, TCPC_REG_ALERT_MASK, mask);