diff options
| author | Diana Z <dzigterman@chromium.org> | 2021-07-21 09:56:40 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-08-14 06:06:39 +0000 |
| commit | ab1cdf1648d390619848f4f4f901b14aeee75244 (patch) | |
| tree | 74b814ec98390eabb46c4a012adbc501c70e9df2 /driver/usb_mux/ps8822.c | |
| parent | 80b43435ca89510e985481b725a470566fb65a05 (diff) | |
| download | chrome-ec-ab1cdf1648d390619848f4f4f901b14aeee75244.tar.gz | |
USB MUX: Generalize mux ACK
Currently, only the virtual mux driver uses the mux ACK feature, but the
actual wait for the host command ACK is a part of the usb_mux general
code. Generalize this mux ACK wait so it's available if needed in the
future for more muxes.
Additionally, moving this wait out of the mux set will allow us to lock
the muxes intelligently between tasks, without keeping the muxes locked
during the inactive ACK wait.
BRANCH=None
BUG=b:172222942,b:186777984
TEST=tast typec.Mode*.manual on voxel
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I61a043425a482cc6f3170548c888d91ec20c2a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3078411
Reviewed-by: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'driver/usb_mux/ps8822.c')
| -rw-r--r-- | driver/usb_mux/ps8822.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/driver/usb_mux/ps8822.c b/driver/usb_mux/ps8822.c index f7a60df6fa..7f25db37f4 100644 --- a/driver/usb_mux/ps8822.c +++ b/driver/usb_mux/ps8822.c @@ -79,11 +79,15 @@ static int ps8822_init(const struct usb_mux *me) } /* Writes control register to set switch mode */ -static int ps8822_set_mux(const struct usb_mux *me, mux_state_t mux_state) +static int ps8822_set_mux(const struct usb_mux *me, mux_state_t mux_state, + bool *ack_required) { int reg; int rv; + /* This driver does not use host command ACKs */ + *ack_required = false; + rv = ps8822_read(me, PS8822_REG_PAGE0, PS8822_REG_MODE, ®); if (rv) return rv; |