diff options
| author | Madhusudanarao Amara <madhusudanarao.amara@intel.corp-partner.google.com> | 2021-01-19 11:06:00 +0530 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-01-21 06:17:59 +0000 |
| commit | 05dbb0a1d8647f9468f7d6400e4013aa5258063a (patch) | |
| tree | 3803c8b7f26efbd0062ad7d791607939fb4814c5 /driver/usb_mux/usb_mux.c | |
| parent | 1a84412cb2c7a06b6f091444f2d141e3018300f5 (diff) | |
| download | chrome-ec-05dbb0a1d8647f9468f7d6400e4013aa5258063a.tar.gz | |
usb_mux: Correction in sending the Host event IRQ=0
Retimer is the first mux and the virtual mux is the second Mux.
Here the check should be for virtual Mux (second mux) instead
checked for the first Mux. Because of that there is no IRQ=0
host events sent.
Removed the condition check as it is taken care in side the
usb_mux_hpd_update function.
BUG=b:177876072
BRANCH=None
TEST=HDMI MST HUB second port display also working
Signed-off-by: Madhusudanarao Amara <madhusudanarao.amara@intel.corp-partner.google.com>
Change-Id: I36205f2d442e9dcaf3d082151201e4c210878d8d
Signed-off-by: Madhusudanarao Amara <madhusudanarao.amara@intel.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2637153
Reviewed-by: Tanu Malhotra <tanu.malhotra@intel.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Diffstat (limited to 'driver/usb_mux/usb_mux.c')
| -rw-r--r-- | driver/usb_mux/usb_mux.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/driver/usb_mux/usb_mux.c b/driver/usb_mux/usb_mux.c index b566383e86..f9b33c9c01 100644 --- a/driver/usb_mux/usb_mux.c +++ b/driver/usb_mux/usb_mux.c @@ -355,7 +355,6 @@ static enum ec_status hc_usb_pd_mux_info(struct host_cmd_handler_args *args) const struct ec_params_usb_pd_mux_info *p = args->params; struct ec_response_usb_pd_mux_info *r = args->response; int port = p->port; - const struct usb_mux *me = &usb_muxes[port]; mux_state_t mux_state; if (port >= board_get_usb_pd_port_count()) @@ -368,8 +367,7 @@ static enum ec_status hc_usb_pd_mux_info(struct host_cmd_handler_args *args) /* Clear HPD IRQ event since we're about to inform host of it. */ if (IS_ENABLED(CONFIG_USB_MUX_VIRTUAL) && - (r->flags & USB_PD_MUX_HPD_IRQ) && - (me->hpd_update == &virtual_hpd_update)) { + (r->flags & USB_PD_MUX_HPD_IRQ)) { usb_mux_hpd_update(port, r->flags & USB_PD_MUX_HPD_LVL, 0); } |