diff options
| author | Peter Marheine <pmarheine@chromium.org> | 2023-05-04 13:07:16 +1000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-05-05 01:35:32 +0000 |
| commit | d814285d6f6fc36ddc948ed9d65b451bcd0e2b21 (patch) | |
| tree | 5936fd3a46ed8ea53a0c1c19817451002c8b911e /driver | |
| parent | 21a314ea7aad34fc7930ea207d07c6b1eb34b7c9 (diff) | |
| download | chrome-ec-d814285d6f6fc36ddc948ed9d65b451bcd0e2b21.tar.gz | |
sm5803: restore load-bearing ERROR_UNIMPLEMENTED
The OCPC code seems to use ERROR_UNIMPLEMENTED as a signal that it should
do some work, and SUCCESS as a signal that everything has been done.
Always returning success appears to cause incorrect charging behavior:
restore the unconditional ERROR_UNIMPLEMENTED that was removed in commit
ae68afbb5d58ce7af0be3e04f833900b105021cd and change the test to reflect
this.
A note is added to the definition of this driver field to document that
ERROR_UNIMPLEMENTED is an expected normal result.
BUG=b:280530115
TEST=Battery once again charges on Yaviks port C1 when
connected to a charger.
Change-Id: I491247148c523123206fefcdbcde62a92ea8caf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4506012
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Peter Marheine <pmarheine@chromium.org>
Commit-Queue: Peter Marheine <pmarheine@chromium.org>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/charger/sm5803.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/driver/charger/sm5803.c b/driver/charger/sm5803.c index 313a3cd321..391c60956a 100644 --- a/driver/charger/sm5803.c +++ b/driver/charger/sm5803.c @@ -1952,7 +1952,7 @@ static enum ec_error_list sm5803_set_vsys_compensation(int chgnum, if (rv) return EC_ERROR_UNKNOWN; - return EC_SUCCESS; + return EC_ERROR_UNIMPLEMENTED; } /* Hardware current ramping (aka DPM: Dynamic Power Management) */ |