diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2022-05-18 10:49:41 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-05-19 00:51:26 +0000 |
| commit | a4e12e3903c995f44d9bbc3d82d0e45ccbc613e4 (patch) | |
| tree | 9fa7c40ea2e3728778b54225f8ed38211dc732d0 /driver | |
| parent | 92d7957d470f0660395bfaf9e9186057817dbd6a (diff) | |
| download | chrome-ec-a4e12e3903c995f44d9bbc3d82d0e45ccbc613e4.tar.gz | |
is31fl3743b: Remove reads for write-only registers
The config register and PU/PD register are write-only. This patch
removes the code reading them.
BUG=b:233099161
BRANCH=None
TEST=Vell
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: Ied0197307ce73f3f1caae8e86e42254ccc217612
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3654483
Reviewed-by: Parth Malkan <parthmalkan@google.com>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/led/is31fl3743b.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/driver/led/is31fl3743b.c b/driver/led/is31fl3743b.c index c62ca00b68..64e9bd58a1 100644 --- a/driver/led/is31fl3743b.c +++ b/driver/led/is31fl3743b.c @@ -45,6 +45,7 @@ struct is31fl3743b_msg { uint8_t payload[]; } __packed; +__maybe_unused static int is31fl3743b_read(struct rgbkbd *ctx, uint8_t addr, uint8_t *value) { uint8_t buf[8]; @@ -86,11 +87,7 @@ static int is31fl3743b_enable(struct rgbkbd *ctx, bool enable) gpio_set_level(GPIO_RGBKBD_SDB_L, enable ? 1 : 0); - rv = is31fl3743b_read(ctx, IS31FL3743B_REG_CONFIG, &u8); - if (rv) { - return rv; - } - + u8 = 0; WRITE_BIT(u8, 3, 1); WRITE_BIT(u8, 0, enable); @@ -167,12 +164,6 @@ static int is31fl3743b_init(struct rgbkbd *ctx) rv = is31fl3743b_reset(ctx); msleep(3); - if (IS_ENABLED(CONFIG_RGB_KEYBOARD_DEBUG)) { - uint8_t val; - rv = is31fl3743b_read(ctx, IS31FL3743B_REG_PD_PU, &val); - CPRINTS("PD/PU. val=0x%02x (rv=%d)", val, rv); - } - return EC_SUCCESS; } |