diff options
| author | Caveh Jalali <caveh@chromium.org> | 2021-11-16 18:27:08 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-11-18 23:45:57 +0000 |
| commit | 2548cc6c6abd23df1ca495d3ed4a40e84672810c (patch) | |
| tree | 1a2e7fb1791903abcba4bca980e16ac8839ea926 /driver | |
| parent | 54f15eaa4a2e8b849318921794445e174d155080 (diff) | |
| download | chrome-ec-2548cc6c6abd23df1ca495d3ed4a40e84672810c.tar.gz | |
bq25710: Update bq25710 BATOC_VTH definitions
This updates the bq25710 register definitions based on the February 2021
datasheet revision. The updated bq25710 definitions matche the bq25720,
so we can simplify BATOC_VTH handling.
BRANCH=none
BUG=b:185190976
TEST=buildall passes
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Change-Id: I6c6e6989545b5f58c276e11b99dda551ba68c7e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3288755
Reviewed-by: Boris Mittelberg <bmbm@google.com>
Commit-Queue: Boris Mittelberg <bmbm@google.com>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/charger/bq25710.c | 7 | ||||
| -rw-r--r-- | driver/charger/bq257x0_regs.h | 18 |
2 files changed, 5 insertions, 20 deletions
diff --git a/driver/charger/bq25710.c b/driver/charger/bq25710.c index d3aeb354af..baf7e7b59c 100644 --- a/driver/charger/bq25710.c +++ b/driver/charger/bq25710.c @@ -399,12 +399,7 @@ static int bq257x0_init_charge_option_2(int chgnum) if (IS_ENABLED(CONFIG_CHARGER_BQ25710_BATOC_VTH_MINIMUM)) { /* Set battery over-current threshold to minimum. */ - if (IS_ENABLED(CONFIG_CHARGER_BQ25720)) - reg = SET_BQ_FIELD_BY_NAME(BQ25720, CHARGE_OPTION_2, - BATOC_VTH, 1P33, reg); - else - reg = SET_BQ_FIELD_BY_NAME(BQ25710, CHARGE_OPTION_2, - BATOC_VTH, 1P50, reg); + reg = SET_CO2_BY_NAME(BATOC_VTH, 1P33, reg); } return raw_write16(chgnum, BQ25710_REG_CHARGE_OPTION_2, reg); diff --git a/driver/charger/bq257x0_regs.h b/driver/charger/bq257x0_regs.h index 0df033f535..63956aff44 100644 --- a/driver/charger/bq257x0_regs.h +++ b/driver/charger/bq257x0_regs.h @@ -73,20 +73,10 @@ #define BQ257X0_CHARGE_OPTION_2_ACOC_VTH__1P33 0 #define BQ257X0_CHARGE_OPTION_2_ACOC_VTH__2P00 1 -#define BQ257X0_CHARGE_OPTION_2_ACOC_VTH_SHIFT 2 -#define BQ257X0_CHARGE_OPTION_2_ACOC_VTH_BITS 1 -#define BQ257X0_CHARGE_OPTION_2_ACOC_VTH__1P33 0 -#define BQ257X0_CHARGE_OPTION_2_ACOC_VTH__2P00 1 - -#define BQ25710_CHARGE_OPTION_2_BATOC_VTH_SHIFT 0 -#define BQ25710_CHARGE_OPTION_2_BATOC_VTH_BITS 1 -#define BQ25710_CHARGE_OPTION_2_BATOC_VTH__1P50 0 -#define BQ25710_CHARGE_OPTION_2_BATOC_VTH__2P00 1 - -#define BQ25720_CHARGE_OPTION_2_BATOC_VTH_SHIFT 0 -#define BQ25720_CHARGE_OPTION_2_BATOC_VTH_BITS 1 -#define BQ25720_CHARGE_OPTION_2_BATOC_VTH__1P33 0 -#define BQ25720_CHARGE_OPTION_2_BATOC_VTH__2P00 1 +#define BQ257X0_CHARGE_OPTION_2_BATOC_VTH_SHIFT 0 +#define BQ257X0_CHARGE_OPTION_2_BATOC_VTH_BITS 1 +#define BQ257X0_CHARGE_OPTION_2_BATOC_VTH__1P33 0 +#define BQ257X0_CHARGE_OPTION_2_BATOC_VTH__2P00 1 /* * ChargeOption3 Register (0x32) |