summaryrefslogtreecommitdiff
path: root/driver
diff options
context:
space:
mode:
authorNicolas Boichat <drinkcat@chromium.org>2018-01-09 16:31:44 +0800
committerchrome-bot <chrome-bot@chromium.org>2018-01-10 06:02:13 -0800
commit31e68a035b83acf13b73f3b5b63fbb99540faea9 (patch)
treee9d3af5cb1d176487fd1994a70eba4f86949df50 /driver
parent1caa2788c5198f3a89e022a559191b27b93adada (diff)
downloadchrome-ec-31e68a035b83acf13b73f3b5b63fbb99540faea9.tar.gz
driver/charger/isl923x: Make sure CONFIG_CHARGER_NARROW_VDC is set
Without this, the battery will discharge if we disallow battery charging (e.g. calling charge_request with either voltage == 0 or current == 0, either by policy, or when the battery is full). Also update config.h to set the option whenever isl923x is used. BRANCH=none BUG=b:66575472 BUG=b:35585464 TEST=make buildall -j Change-Id: Id5515d5ea82a393a3693a3da44cbdc2778296a95 Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/856538 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'driver')
-rw-r--r--driver/charger/isl923x.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/driver/charger/isl923x.c b/driver/charger/isl923x.c
index 0117ad74d4..5f6312c7c7 100644
--- a/driver/charger/isl923x.c
+++ b/driver/charger/isl923x.c
@@ -18,6 +18,10 @@
#include "timer.h"
#include "util.h"
+#ifndef CONFIG_CHARGER_NARROW_VDC
+#error "ISL9237/8 is a NVDC charger, please enable CONFIG_CHARGER_NARROW_VDC."
+#endif
+
#define DEFAULT_R_AC 20
#define DEFAULT_R_SNS 10
#define R_AC CONFIG_CHARGER_SENSE_RESISTOR_AC