diff options
| author | Jett Rink <jettrink@chromium.org> | 2018-04-23 12:53:20 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-04-23 21:48:19 -0700 |
| commit | 6b57b4b3900c81bd652e51839b1499025bbdfac4 (patch) | |
| tree | 01563d15a04b10680335b6ebdecb2febdd862ea7 /driver | |
| parent | b40f6e5939826d88421620a5b34f8444ea202193 (diff) | |
| download | chrome-ec-6b57b4b3900c81bd652e51839b1499025bbdfac4.tar.gz | |
ps8751: add note to revert vbus detection workaround
Once the PS8751 has new firmware, it will be able to detect VBus
at the appropriate time. After that, we can go back to using the
cached version of Vbus detection.
BRANCH=none
BUG=b:77639399
TEST=none
Change-Id: I691919f3bd2479a131aa58763c7906cb4f6919ff
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1024531
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/tcpm/ps8xxx.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/driver/tcpm/ps8xxx.c b/driver/tcpm/ps8xxx.c index 21a20566ff..8a5dedb9d3 100644 --- a/driver/tcpm/ps8xxx.c +++ b/driver/tcpm/ps8xxx.c @@ -95,8 +95,11 @@ int ps8xxx_tcpc_get_fw_version(int port, int *version) #ifdef CONFIG_USB_PD_VBUS_DETECT_TCPC /* * Read Vbus level directly instead of using the cached version because some - * TPCPs do not fire the Vbus level change interrupt correctly after resuming + * TCPCs do not fire the Vbus level change interrupt correctly after resuming * from low-power mode. + * + * TODO(b/77639399): Remove this method once PS8751 firmware has updated to + * support better handling of vbus detection */ int ps8xxx_tcpm_get_vbus_level(int port) { @@ -160,6 +163,10 @@ const struct tcpm_drv ps8xxx_tcpm_drv = { .release = &ps8xxx_tcpm_release, .get_cc = &tcpci_tcpm_get_cc, #ifdef CONFIG_USB_PD_VBUS_DETECT_TCPC +/* + * TODO(b/77639399): Replace with tcpci_tcpm_get_vbus_level() after firmware + * upgrade. + */ .get_vbus_level = &ps8xxx_tcpm_get_vbus_level, #endif .select_rp_value = &tcpci_tcpm_select_rp_value, |