diff options
| author | Jett Rink <jettrink@chromium.org> | 2018-10-12 09:48:25 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-10-12 15:16:49 -0700 |
| commit | 91fd6c54d03f919d97ca4151191eb7a9a11f85dc (patch) | |
| tree | 11463be0b82dab09558e0897366807130d5992ec /driver | |
| parent | 2dc1ac3ffcbef2da74f717472b8404ba5bc65e1e (diff) | |
| download | chrome-ec-91fd6c54d03f919d97ca4151191eb7a9a11f85dc.tar.gz | |
cleanup: rename Rp enum values for clarity
The tcpc_cc_voltage_status enum contains different values for different
detected resister values of the port partner. Both Ra and Rd values
contained that in the name, but Rp values did not. Update _SNK_ tag to
_RP_ tag to make it more clear what resistor is being applied by port
partner.
Also adding a few more comments in usb_pd_tcpm.h for clarify on the
different uses of CC resistor enums.
BRANCH=none
BUG=none
TEST=builds. just a rename change.
Change-Id: Id5f7bb502f735bef5937585e2e8bd516ad428a99
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1278103
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/tcpm/anx74xx.c | 6 | ||||
| -rw-r--r-- | driver/tcpm/fusb302.c | 6 | ||||
| -rw-r--r-- | driver/tcpm/it83xx.c | 6 |
3 files changed, 9 insertions, 9 deletions
diff --git a/driver/tcpm/anx74xx.c b/driver/tcpm/anx74xx.c index e0c01f52dc..22f1f51e77 100644 --- a/driver/tcpm/anx74xx.c +++ b/driver/tcpm/anx74xx.c @@ -587,15 +587,15 @@ static int anx74xx_check_cc_type(int cc_reg) break; case BIT_VALUE_OF_SNK_CC_DEFAULT: - cc = TYPEC_CC_VOLT_SNK_DEF; + cc = TYPEC_CC_VOLT_RP_DEF; break; case BIT_VALUE_OF_SNK_CC_1_P_5: - cc = TYPEC_CC_VOLT_SNK_1_5; + cc = TYPEC_CC_VOLT_RP_1_5; break; case BIT_VALUE_OF_SNK_CC_3_P_0: - cc = TYPEC_CC_VOLT_SNK_3_0; + cc = TYPEC_CC_VOLT_RP_3_0; break; default: diff --git a/driver/tcpm/fusb302.c b/driver/tcpm/fusb302.c index 68cf14774d..7b736e5b23 100644 --- a/driver/tcpm/fusb302.c +++ b/driver/tcpm/fusb302.c @@ -91,11 +91,11 @@ static int convert_bc_lvl(int port, int bc_lvl) ret = TYPEC_CC_VOLT_RD; } else { if (bc_lvl == 0x1) - ret = TYPEC_CC_VOLT_SNK_DEF; + ret = TYPEC_CC_VOLT_RP_DEF; else if (bc_lvl == 0x2) - ret = TYPEC_CC_VOLT_SNK_1_5; + ret = TYPEC_CC_VOLT_RP_1_5; else if (bc_lvl == 0x3) - ret = TYPEC_CC_VOLT_SNK_3_0; + ret = TYPEC_CC_VOLT_RP_3_0; } return ret; diff --git a/driver/tcpm/it83xx.c b/driver/tcpm/it83xx.c index 8fb6b985c0..f4783c1725 100644 --- a/driver/tcpm/it83xx.c +++ b/driver/tcpm/it83xx.c @@ -84,13 +84,13 @@ static enum tcpc_cc_voltage_status it83xx_get_cc( switch (ufp_volt) { case USBPD_UFP_STATE_SNK_DEF: - cc_state |= (TYPEC_CC_VOLT_SNK_DEF & 3); + cc_state |= (TYPEC_CC_VOLT_RP_DEF & 3); break; case USBPD_UFP_STATE_SNK_1_5: - cc_state |= (TYPEC_CC_VOLT_SNK_1_5 & 3); + cc_state |= (TYPEC_CC_VOLT_RP_1_5 & 3); break; case USBPD_UFP_STATE_SNK_3_0: - cc_state |= (TYPEC_CC_VOLT_SNK_3_0 & 3); + cc_state |= (TYPEC_CC_VOLT_RP_3_0 & 3); break; case USBPD_UFP_STATE_SNK_OPEN: cc_state = TYPEC_CC_VOLT_OPEN; |