diff options
| author | Nicolas Boichat <drinkcat@chromium.org> | 2018-10-24 12:56:42 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-10-24 05:36:32 -0700 |
| commit | 11e2cf2c6b99f329e0446bd8167ffb14a98750d2 (patch) | |
| tree | f8f0ed0e7f327dca309941d0a8230fa43ed5ce79 /driver | |
| parent | 79b789e1e06968fc22d51a5f3208ee8cf4ae8022 (diff) | |
| download | chrome-ec-11e2cf2c6b99f329e0446bd8167ffb14a98750d2.tar.gz | |
driver/touchpad_st: Ignore st_tp_reset return value
Workaround for the bug described in b/118312397. Without this,
EC FW is not able to request Full Panel Initialization (FPI), in
some specific cases, if the last FPI on ST FW 32 previously failed.
BUG=b:118312397
TEST=
1. Flash whiskers_v2.2.75-3a719f70b.fw (32.0)
2. During FPI, disconnect the base
3. Flash whiskers_v2.2.88-6c5576913.fw (34.0)
4. EC FW is unable to run FPI
This FW fixes the issue in 4, and FPI is run on boot, when the
EC FW realizes that Cx table is invalid.
BRANCH=whiskers
Change-Id: Ifb817d2c7d4a9311f3273b46964903b0f94dcdae
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1297092
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/touchpad_st.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/driver/touchpad_st.c b/driver/touchpad_st.c index c92da46bca..43a66874be 100644 --- a/driver/touchpad_st.c +++ b/driver/touchpad_st.c @@ -1109,8 +1109,11 @@ static int st_tp_panel_init(int full) st_tp_stop_scan(); ret = st_tp_reset(); - if (ret) - return ret; + /* + * TODO(b:118312397): Figure out how to handle st_tp_reset errors (if + * needed at all). + */ + CPRINTS("st_tp_reset ret=%d", ret); full |= tp_control & TP_CONTROL_SHALL_INIT_FULL; if (full) { |