diff options
| author | Zick Wei <zick.wei@quanta.corp-partner.google.com> | 2021-12-10 11:14:39 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-12-20 05:07:26 +0000 |
| commit | d6a4b19c732a9b690baa12a90614b1506a2e61c5 (patch) | |
| tree | 0997a07af6abb350dbf1d4f215b0f5843fc0ae80 /driver | |
| parent | bb144c51ff198ea1907b65068e33dd4f90c6aa7c (diff) | |
| download | chrome-ec-d6a4b19c732a9b690baa12a90614b1506a2e61c5.tar.gz | |
cleanup: driver/led: oz554 and mp3385
Cleanup oz554 and mp3385 low level driver,
for more compatible with boards.
BUG=b:208722790
BRANCH=none
TEST=make BOARD=dooly, make BOARD=karma
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Ia0169099c0315843fbd5b567b4538aa823f02a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3329187
Reviewed-by: Andrew McRae <amcrae@google.com>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/led/mp3385.c | 2 | ||||
| -rw-r--r-- | driver/led/mp3385.h | 2 | ||||
| -rw-r--r-- | driver/led/oz554.c | 15 | ||||
| -rw-r--r-- | driver/led/oz554.h | 4 |
4 files changed, 5 insertions, 18 deletions
diff --git a/driver/led/mp3385.c b/driver/led/mp3385.c index 825412e647..278e333ae1 100644 --- a/driver/led/mp3385.c +++ b/driver/led/mp3385.c @@ -97,7 +97,7 @@ static void mp3385_backlight_enable_deferred(void) } DECLARE_DEFERRED(mp3385_backlight_enable_deferred); -void backlight_enable_interrupt(enum gpio_signal signal) +void mp3385_interrupt(enum gpio_signal signal) { /* * 1. Spec says backlight should be turned on after 500ms diff --git a/driver/led/mp3385.h b/driver/led/mp3385.h index 74d796ad3a..9463b06aa5 100644 --- a/driver/led/mp3385.h +++ b/driver/led/mp3385.h @@ -30,6 +30,6 @@ int mp3385_set_config(int offset, int data); #define MP3385_POWER_BACKLIGHT_DELAY SECOND #endif -void backlight_enable_interrupt(enum gpio_signal signal); +void mp3385_interrupt(enum gpio_signal signal); #endif diff --git a/driver/led/oz554.c b/driver/led/oz554.c index 504ac55e90..4b661a592c 100644 --- a/driver/led/oz554.c +++ b/driver/led/oz554.c @@ -98,7 +98,7 @@ static void backlight_enable_deferred(void) } DECLARE_DEFERRED(backlight_enable_deferred); -void backlight_enable_interrupt(enum gpio_signal signal) +void oz554_interrupt(enum gpio_signal signal) { /* * 1. Spec says backlight should be turned on after 500ms @@ -132,16 +132,3 @@ int oz554_set_config(int offset, int data) oz554_conf[i].data = data; return EC_SUCCESS; } - -static void init_oz554(void) -{ - oz554_board_init(); - - gpio_enable_interrupt(GPIO_PANEL_BACKLIGHT_EN); -} -DECLARE_HOOK(HOOK_INIT, init_oz554, HOOK_PRIO_DEFAULT); - - -__overridable void oz554_board_init(void) -{ -} diff --git a/driver/led/oz554.h b/driver/led/oz554.h index d1d9d9656e..1893900b22 100644 --- a/driver/led/oz554.h +++ b/driver/led/oz554.h @@ -15,7 +15,7 @@ * Overridable board initialization. Should be overridden by a board * specific function if the default is not appropriate */ -__override_proto void oz554_board_init(void); +void oz554_board_init(void); /** * Update oz554 configuration array (oz554_conf). @@ -30,6 +30,6 @@ int oz554_set_config(int offset, int data); #define OZ554_POWER_BACKLIGHT_DELAY SECOND #endif -void backlight_enable_interrupt(enum gpio_signal signal); +void oz554_interrupt(enum gpio_signal signal); #endif |