diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2022-07-11 10:21:49 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-07-13 15:46:35 +0000 |
| commit | c8282f61e105490ed50120ec2d6a83a1e2ec1e08 (patch) | |
| tree | 73047f4ef11b26e46ef90795a1c74c3c03932394 /driver | |
| parent | cce493a388878334a65af95c4313ee051ef8a546 (diff) | |
| download | chrome-ec-c8282f61e105490ed50120ec2d6a83a1e2ec1e08.tar.gz | |
tree: Check return value from snprintf
snprintf returns a negative value on failure. The return value should be
checked to make sure that there were no errors.
BRANCH=none
BUG=b:238433667, b:234181908
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I64e2e69df7fa22c94f19acbbca8c6afbe6cf1ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3756174
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/battery/max17055.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/driver/battery/max17055.c b/driver/battery/max17055.c index 382995d0df..88d58eb659 100644 --- a/driver/battery/max17055.c +++ b/driver/battery/max17055.c @@ -92,10 +92,13 @@ int battery_device_name(char *device_name, int buf_size) int rv; rv = max17055_read(REG_DEVICE_NAME, &dev_id); - if (!rv) - snprintf(device_name, buf_size, "0x%04x", dev_id); + if (rv != EC_SUCCESS) + return rv; - return rv; + if (snprintf(device_name, buf_size, "0x%04x", dev_id) <= 0) + return EC_ERROR_UNKNOWN; + + return EC_SUCCESS; } int battery_state_of_charge_abs(int *percent) |