diff options
| author | Andrew McRae <amcrae@google.com> | 2020-05-29 23:25:43 +1000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-10 17:27:16 +0000 |
| commit | 42cc4b011b641ad04bce7faba212d8d7110af439 (patch) | |
| tree | 0f8ef892f5c556c2c89d98ed8a25c1adce2162a0 /driver | |
| parent | 3dc4147d8792447671b3a37726e4f62f72c0db8b (diff) | |
| download | chrome-ec-42cc4b011b641ad04bce7faba212d8d7110af439.tar.gz | |
ANX7447: Cleanup spurious register access
Remove access to unknown registers.
Neither of these 2 registers have any known use that
seems to match how they are being accessed, and one of the
registers has a completely different definition in the official
documentation.
Analogix has confirmed that this code was only used for testing
at the start of the porting process, and can be removed.
BUG=b:158044100
TEST=Build and verify normal functionality on Puff.
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: I70a814623a6383a4948b84437fe5df9d762e884e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2222384
Tested-by: Andrew McRae <amcrae@chromium.org>
Commit-Queue: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/tcpm/anx7447.c | 44 |
1 files changed, 0 insertions, 44 deletions
diff --git a/driver/tcpm/anx7447.c b/driver/tcpm/anx7447.c index 438bc03234..28fb702ef7 100644 --- a/driver/tcpm/anx7447.c +++ b/driver/tcpm/anx7447.c @@ -19,16 +19,6 @@ #define CPRINTS(format, args...) cprints(CC_USBCHARGE, format, ## args) #define CPRINTF(format, args...) cprintf(CC_USBCHARGE, format, ## args) -#define ANX7447_VENDOR_ALERT BIT(15) - -#define ANX7447_REG_STATUS 0x82 -#define ANX7447_REG_STATUS_LINK BIT(0) - -#define ANX7447_REG_HPD 0x83 -#define ANX7447_REG_HPD_HIGH BIT(0) -#define ANX7447_REG_HPD_IRQ BIT(1) -#define ANX7447_REG_HPD_ENABLE BIT(2) - #define vsafe5v_min (3800/25) #define vsafe0v_max (800/25) /* @@ -411,25 +401,6 @@ static int anx7447_release(int port) return EC_SUCCESS; } -static void anx7447_update_hpd_enable(int port) -{ - int status, reg, rv; - - rv = tcpc_read(port, ANX7447_REG_STATUS, &status); - rv |= tcpc_read(port, ANX7447_REG_HPD, ®); - if (rv) - return; - - if (!(reg & ANX7447_REG_HPD_ENABLE) || - !(status & ANX7447_REG_STATUS_LINK)) { - reg &= ~ANX7447_REG_HPD_IRQ; - tcpc_write(port, ANX7447_REG_HPD, - (status & ANX7447_REG_STATUS_LINK) - ? reg | ANX7447_REG_HPD_ENABLE - : reg & ~ANX7447_REG_HPD_ENABLE); - } -} - #ifdef CONFIG_USB_PD_VBUS_DETECT_TCPC static int anx7447_get_vbus_voltage(int port) { @@ -467,14 +438,8 @@ int anx7447_board_charging_enable(int port, int enable) static void anx7447_tcpc_alert(int port) { - int alert, rv; - - rv = tcpc_read16(port, TCPC_REG_ALERT, &alert); /* process and clear alert status */ tcpci_tcpc_alert(port); - - if (!rv && (alert & ANX7447_VENDOR_ALERT)) - anx7447_update_hpd_enable(port); } /* @@ -742,11 +707,6 @@ static int anx7447_set_polarity(int port, #ifdef CONFIG_CMD_TCPC_DUMP static const struct tcpc_reg_dump_map anx7447_regs[] = { { - .addr = ANX7447_REG_STATUS, - .name = "ANX7447_STATUS", - .size = 1, - }, - { .addr = ANX7447_REG_ADC_CTRL_1, .name = "ADC_CTRL_1", .size = 1, @@ -773,10 +733,6 @@ const struct { uint8_t addr; } anx7447_alt_regs[] = { { - .addr = ANX7447_REG_HPD, - .name = "HPD", - }, - { .name = "HPD_CTRL_0", .addr = ANX7447_REG_HPD_CTRL_0, }, |