cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.

We're never going to use this, let's just get rid of it.

BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware

Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.

Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

18 files changed, 29 insertions, 54 deletions

diff --git a/driver/battery/bq27541.c b/driver/battery/bq27541.c
index ae9f024cc2..760a367b9c 100644
--- a/driver/battery/bq27541.c
+++ b/driver/battery/bq27541.c
@@ -353,6 +353,5 @@ static int command_battfake(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(battfake, command_battfake,
 			"percent (-1 = use real level)",
-			"Set fake battery level",
-			NULL);
+			"Set fake battery level");
 
diff --git a/driver/battery/bq27621_g1.c b/driver/battery/bq27621_g1.c
index e08e700522..c55d452c87 100644
--- a/driver/battery/bq27621_g1.c
+++ b/driver/battery/bq27621_g1.c
@@ -576,8 +576,7 @@ static int command_fgunseal(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(fgunseal, command_fgunseal,
 			"",
-			"Unseal the fg",
-			NULL);
+			"Unseal the fg");
 
 static int command_fgseal(int argc, char **argv)
 {
@@ -593,8 +592,7 @@ static int command_fgseal(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(fgseal, command_fgseal,
 			"",
-			"Seal the fg",
-			NULL);
+			"Seal the fg");
 
 static int command_fginit(int argc, char **argv)
 {
@@ -629,8 +627,7 @@ static int command_fginit(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(fginit, command_fginit,
 			"[force]",
-			"Initialize the fg",
-			NULL);
+			"Initialize the fg");
 
 static int command_fgprobe(int argc, char **argv)
 {
@@ -646,8 +643,7 @@ static int command_fgprobe(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(fgprobe, command_fgprobe,
 			"",
-			"Probe the fg",
-			NULL);
+			"Probe the fg");
 
 static int command_fgrd(int argc, char **argv)
 {
@@ -681,8 +677,7 @@ static int command_fgrd(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(fgrd, command_fgrd,
 			"cmd len",
-			"Read _len_ words from the fg",
-			NULL);
+			"Read _len_ words from the fg");
 
 static int command_fgcmd(int argc, char **argv)
 {
@@ -718,8 +713,7 @@ static int command_fgcmd(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(fgcmd, command_fgcmd,
 			"cmd data [byte]",
-			"Send a cmd to the fg",
-			NULL);
+			"Send a cmd to the fg");
 
 static int command_fgcmdrd(int argc, char **argv)
 {
@@ -747,8 +741,7 @@ static int command_fgcmdrd(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(fgcmdrd, command_fgcmdrd,
 			"cmd data",
-			"Send a 2-byte cmd to the fg, read back the 2-byte result",
-			NULL);
+			"Send a 2-byte cmd to the fg, read back the 2-byte result");
 
 #endif /* CONFIG_CMD_BATDEBUG */
 
diff --git a/driver/battery/smart.c b/driver/battery/smart.c
index 6f884a55b3..ff2da13863 100644
--- a/driver/battery/smart.c
+++ b/driver/battery/smart.c
@@ -396,8 +396,7 @@ static int command_battfake(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(battfake, command_battfake,
 			"percent (-1 = use real level)",
-			"Set fake battery level",
-			NULL);
+			"Set fake battery level");
 #endif
 
 /*****************************************************************************/
diff --git a/driver/charger/bd99955.c b/driver/charger/bd99955.c
index 4aa4311cfb..c12b7949a5 100644
--- a/driver/charger/bd99955.c
+++ b/driver/charger/bd99955.c
@@ -956,8 +956,7 @@ static int console_bd99955_dump_regs(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(bd99955_dump, console_bd99955_dump_regs,
 			NULL,
-			"Dump all charger registers",
-			NULL);
+			"Dump all charger registers");
 
 static int console_command_bd99955(int argc, char **argv)
 {
@@ -1001,8 +1000,7 @@ static int console_command_bd99955(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(bd99955, console_command_bd99955,
 			"bd99955 <r/w> <reg_hex> <cmd_type> | <val_hex>",
-			"Read or write a charger register",
-			NULL);
+			"Read or write a charger register");
 #endif /* CONFIG_CMD_CHARGER */
 
 #ifdef CONFIG_CMD_CHARGER_PSYS
@@ -1068,8 +1066,7 @@ static int console_command_psys(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(psys, console_command_psys,
 			NULL,
-			"Get the system power in mW",
-			NULL);
+			"Get the system power in mW");
 #endif /* CONFIG_CMD_CHARGER_PSYS */
 
 #ifdef CONFIG_CMD_CHARGER_ADC_AMON_BMON
@@ -1160,6 +1157,5 @@ static int console_command_amon_bmon(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(amonbmon, console_command_amon_bmon,
 			"amonbmon [a|b]",
-			"Get charger AMON/BMON voltage diff, current",
-			NULL);
+			"Get charger AMON/BMON voltage diff, current");
 #endif /* CONFIG_CMD_CHARGER_ADC_AMON_BMON */
diff --git a/driver/charger/bq24192.c b/driver/charger/bq24192.c
index 2bc6697d6e..defc97115e 100644
--- a/driver/charger/bq24192.c
+++ b/driver/charger/bq24192.c
@@ -271,5 +271,5 @@ static int command_bq24192(int argc, char **argv)
 	return EC_SUCCESS;
 }
 DECLARE_CONSOLE_COMMAND(bq24192, command_bq24192,
-			NULL, NULL, NULL);
+			NULL, NULL);
 #endif
diff --git a/driver/charger/bq2589x.c b/driver/charger/bq2589x.c
index e36007f16a..9586393c4c 100644
--- a/driver/charger/bq2589x.c
+++ b/driver/charger/bq2589x.c
@@ -388,5 +388,5 @@ static int command_bq2589x(int argc, char **argv)
 	return EC_SUCCESS;
 }
 DECLARE_CONSOLE_COMMAND(bq2589x, command_bq2589x,
-			NULL, NULL, NULL);
+			NULL, NULL);
 #endif
diff --git a/driver/charger/isl9237.c b/driver/charger/isl9237.c
index 94b8669ce6..3be623ff00 100644
--- a/driver/charger/isl9237.c
+++ b/driver/charger/isl9237.c
@@ -412,8 +412,7 @@ static int console_command_psys(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(psys, console_command_psys,
 			NULL,
-			"Get the system power in mW",
-			NULL);
+			"Get the system power in mW");
 #endif /* CONFIG_CMD_CHARGER_PSYS */
 #endif /* CONFIG_CHARGER_PSYS */
 
@@ -462,6 +461,5 @@ static int console_command_amon_bmon(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(amonbmon, console_command_amon_bmon,
 			"amonbmon [a|b]",
-			"Get charger AMON/BMON voltage diff, current",
-			NULL);
+			"Get charger AMON/BMON voltage diff, current");
 #endif /* CONFIG_CMD_CHARGER_ADC_AMON_BMON */
diff --git a/driver/ina2xx.c b/driver/ina2xx.c
index 34a928fb33..d610285710 100644
--- a/driver/ina2xx.c
+++ b/driver/ina2xx.c
@@ -143,6 +143,5 @@ static int command_ina(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(ina, command_ina,
 			"<index> [config|calib|mask|alert <val>]",
-			"INA2XX power/current sensing",
-			NULL);
+			"INA2XX power/current sensing");
 #endif
diff --git a/driver/led/ds2413.c b/driver/led/ds2413.c
index 8364688e28..0ba713f27f 100644
--- a/driver/led/ds2413.c
+++ b/driver/led/ds2413.c
@@ -162,6 +162,5 @@ static int command_powerled(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(powerled, command_powerled,
 			"<off | red | yellow | green>",
-			"Set power LED color",
-			NULL);
+			"Set power LED color");
 #endif
diff --git a/driver/led/lp5562.c b/driver/led/lp5562.c
index 669057b728..88efb72e7b 100644
--- a/driver/led/lp5562.c
+++ b/driver/led/lp5562.c
@@ -156,6 +156,5 @@ static int command_lp5562(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(lp5562, command_lp5562,
 			"on | off | <red> <green> <blue>",
-			"Set the color of the LED",
-			NULL);
+			"Set the color of the LED");
 #endif
diff --git a/driver/mcdp28x0.c b/driver/mcdp28x0.c
index 0a39e5e225..3af0eec0c9 100644
--- a/driver/mcdp28x0.c
+++ b/driver/mcdp28x0.c
@@ -309,6 +309,5 @@ int command_mcdp(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(mcdp, command_mcdp,
 			"info|devid <id>|appstest <cmd> [<params>]",
-			"USB PD",
-			NULL);
+			"USB PD");
 #endif /* CONFIG_CMD_MCDP */
diff --git a/driver/pmu_tps65090.c b/driver/pmu_tps65090.c
index ba3407c81d..665801538a 100644
--- a/driver/pmu_tps65090.c
+++ b/driver/pmu_tps65090.c
@@ -694,8 +694,7 @@ static int command_pmu(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(pmu, command_pmu,
 			"<repeat_count|reset>",
-			"Print PMU info or force a hard reset",
-			NULL);
+			"Print PMU info or force a hard reset");
 #endif
 
 /*****************************************************************************/
diff --git a/driver/pmu_tps65090_powerinfo.c b/driver/pmu_tps65090_powerinfo.c
index 9eb6adca42..3ab4fb26b3 100644
--- a/driver/pmu_tps65090_powerinfo.c
+++ b/driver/pmu_tps65090_powerinfo.c
@@ -112,8 +112,7 @@ static int command_powerinfo(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(powerinfo, command_powerinfo,
 		NULL,
-		"Show PMU power info",
-		NULL);
+		"Show PMU power info");
 
 /**
  * Host command to get power info from PMU
diff --git a/driver/regulator_ir357x.c b/driver/regulator_ir357x.c
index e87094534d..4f65db13e6 100644
--- a/driver/regulator_ir357x.c
+++ b/driver/regulator_ir357x.c
@@ -236,8 +236,7 @@ static int command_ir357x(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(ir357x, command_ir357x,
 			"[check|write]",
-			"IR357x core regulator control",
-			NULL);
+			"IR357x core regulator control");
 #endif
 
 static void ir357x_hot_settings(void)
diff --git a/driver/temp_sensor/g78x.c b/driver/temp_sensor/g78x.c
index 858ae38769..948569da1c 100644
--- a/driver/temp_sensor/g78x.c
+++ b/driver/temp_sensor/g78x.c
@@ -231,5 +231,5 @@ static int command_g78x(int argc, char **argv)
 DECLARE_CONSOLE_COMMAND(g78x, command_g78x,
 	"[settemp|setbyte <offset> <value>] or [getbyte <offset>]. "
 	"Temps in Celsius.",
-	"Print g781/g782 temp sensor status or set parameters.", NULL);
+	"Print g781/g782 temp sensor status or set parameters.");
 #endif
diff --git a/driver/temp_sensor/tmp006.c b/driver/temp_sensor/tmp006.c
index a816f20ec2..9801963ff5 100644
--- a/driver/temp_sensor/tmp006.c
+++ b/driver/temp_sensor/tmp006.c
@@ -436,8 +436,7 @@ static int command_sensor_info(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(tmp006, command_sensor_info,
 			"[ <index> ]",
-			"Print TMP006 sensors",
-			NULL);
+			"Print TMP006 sensors");
 #endif
 
 /* Disable the t6cal command until/unless we have FP support in printf */
@@ -493,6 +492,5 @@ static int command_t6cal(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(t6cal, command_t6cal,
 			"[<index> <coeff_name> <radix>]",
-			"Set/print TMP006 calibration",
-			NULL);
+			"Set/print TMP006 calibration");
 #endif
diff --git a/driver/temp_sensor/tmp432.c b/driver/temp_sensor/tmp432.c
index ea49fcb28b..f288f40ed5 100644
--- a/driver/temp_sensor/tmp432.c
+++ b/driver/temp_sensor/tmp432.c
@@ -330,7 +330,7 @@ DECLARE_CONSOLE_COMMAND(tmp432, command_tmp432,
 	"[settemp|setbyte <offset> <value>] or [getbyte <offset>] or"
 	"[power <on|off>]. "
 	"Temps in Celsius.",
-	"Print tmp432 temp sensor status or set parameters.", NULL);
+	"Print tmp432 temp sensor status or set parameters.");
 #endif
 
 int tmp432_set_power(enum tmp432_power_state power_on)
diff --git a/driver/usb_mux.c b/driver/usb_mux.c
index 05222e1d84..fde578da39 100644
--- a/driver/usb_mux.c
+++ b/driver/usb_mux.c
@@ -152,8 +152,7 @@ static int command_typec(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(typec, command_typec,
 			"[port|debug] [none|usb|dp|dock]",
-			"Control type-C connector muxing",
-			NULL);
+			"Control type-C connector muxing");
 #endif
 
 static int hc_usb_pd_mux_info(struct host_cmd_handler_args *args)