ec: Fix object comparison in the stack analyzer

Handle the case of comparing with different kinds of objects.

BUG=none
BRANCH=none
TEST=extra/stack_analyzer/stack_analyzer_unittest.py

Change-Id: I01056cd39e14d75442d4029b6c64d9843c49cf2a
Signed-off-by: Che-yu Wu <cheyuw@google.com>
Reviewed-on: https://chromium-review.googlesource.com/616367
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

1 files changed, 12 insertions, 0 deletions

diff --git a/extra/stack_analyzer/stack_analyzer.py b/extra/stack_analyzer/stack_analyzer.py
index df7b7c8932..cc9543cc8c 100755
--- a/extra/stack_analyzer/stack_analyzer.py
+++ b/extra/stack_analyzer/stack_analyzer.py
@@ -76,6 +76,9 @@ class Task(object):
     Returns:
       True if equal, False if not.
     """
+    if not isinstance(other, Task):
+      return False
+
     return (self.name == other.name and
             self.routine_name == other.routine_name and
             self.stack_max_size == other.stack_max_size and
@@ -116,6 +119,9 @@ class Symbol(object):
     Returns:
       True if equal, False if not.
     """
+    if not isinstance(other, Symbol):
+      return False
+
     return (self.address == other.address and
             self.symtype == other.symtype and
             self.size == other.size and
@@ -156,6 +162,9 @@ class Callsite(object):
     Returns:
       True if equal, False if not.
     """
+    if not isinstance(other, Callsite):
+      return False
+
     if not (self.address == other.address and
             self.target == other.target and
             self.is_tail == other.is_tail):
@@ -217,6 +226,9 @@ class Function(object):
     Returns:
       True if equal, False if not.
     """
+    if not isinstance(other, Function):
+      return False
+
     # TODO(cheyuw): Don't compare SCC node attributes here.
     if not (self.address == other.address and
             self.name == other.name and