diff options
author | Nick Sanders <nsanders@chromium.org> | 2018-07-26 02:31:10 +0000 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-07-26 04:07:16 -0700 |
commit | 3793a83cbd7349b07453cc5a44674f9e7bc856f3 (patch) | |
tree | e275f6b023dc0014a2ca4e12b2ae557dcd6c0031 /extra/usb_serial/console.py | |
parent | 5110f15fa238acd2e67844531904108245517cbb (diff) | |
download | chrome-ec-3793a83cbd7349b07453cc5a44674f9e7bc856f3.tar.gz |
Revert "ec-devutils: update pyusb to 1.0.2"
This reverts commit 7d26ae49bffcf269df82df7d0fee00e8c3341166.
pyusb 1.0.2 fails under load and locks up the usb endpoint.
BUG=b:111658037, chromium:865482
TEST=while RES=$(dut-control ec_uart_en spi1_buf_en ); do echo ${RES}; done
CQ-DEPEND=CL:1149509
Original change's description:
> ec-devutils: update pyusb to 1.0.2
>
> Pyusb interface has changed yet again. Patch calls to get_string
> and usb.core.find. Modify ordering of detetch kernel driver
> and avoid rereferencing endpoints.
>
> BRANCH=None
> BUG=b:110907544
> TEST=emerge ec-devutils, run powerlog, usb_console, servo_updater
>
> CQ-DEPEND=CL:1119632
>
> Signed-off-by: Nick Sanders <nsanders@chromium.org>
>
> Change-Id: I33df474ce3bb57d2e11c9f384ac013b51d210843
> Reviewed-on: https://chromium-review.googlesource.com/1125354
> Commit-Ready: Nick Sanders <nsanders@chromium.org>
> Tested-by: Nick Sanders <nsanders@chromium.org>
> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Bug: b:110907544
Change-Id: I04f015b4924e7fee76ab0f1734267e8e2d14faaa
Reviewed-on: https://chromium-review.googlesource.com/1150963
Commit-Ready: Nick Sanders <nsanders@chromium.org>
Tested-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Diffstat (limited to 'extra/usb_serial/console.py')
-rwxr-xr-x | extra/usb_serial/console.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/extra/usb_serial/console.py b/extra/usb_serial/console.py index e3288b8593..2494c59c79 100755 --- a/extra/usb_serial/console.py +++ b/extra/usb_serial/console.py @@ -71,8 +71,7 @@ class Susb(): SusbError: An error accessing Susb object """ # Find the device. - dev_g = usb.core.find(idVendor=vendor, idProduct=product, find_all=True) - dev_list = list(dev_g) + dev_list = usb.core.find(idVendor=vendor, idProduct=product, find_all=True) if dev_list is None: raise SusbError("USB device not found") |