diff options
| author | Yoshiki Iguchi <yoshiki@chromium.org> | 2022-09-05 05:25:57 +0000 |
|---|---|---|
| committer | Jim Pollock <jmpollock@chromium.org> | 2022-09-05 05:49:25 +0000 |
| commit | d0f1e73077cda3789206da80cee38505741c9f13 (patch) | |
| tree | e8d0f3749e815cecacab490a2bbb40a83a3c0daa /extra | |
| parent | 1fc90ab17cc84838d4cdd9c2163b5d7db3a9cd3a (diff) | |
| download | chrome-ec-d0f1e73077cda3789206da80cee38505741c9f13.tar.gz | |
Revert "ec: Fix DEBUG "variable" in usb_updater Makefile"
This reverts commit 9bfe90b111b030419871c5035b4dc0063e2f8221.
Reason for revert: This breaks build of chromeos-cr50-dev: b/245028043
Bug: b/245028043
Original change's description:
> ec: Fix DEBUG "variable" in usb_updater Makefile
>
> DEBUG is not the way to refer to a variable in a Makefile expression;
> $(DEBUG) is.
>
> Also, make extra/rma_reset/Makefile consistent.
>
> Drop the EOF blank line to satisfy linter.
>
> BUG=none
> TEST=build
> BRANCH=none
>
> Change-Id: Ic71be497ca83041dfdedf63c10e7c74b38c05bc8
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872546
> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Bug: none
Change-Id: I3695637fb72be8f6ead03b609b4ba0dba7e83452
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872413
Reviewed-by: Jim Pollock <jmpollock@chromium.org>
Tested-by: Jim Pollock <jmpollock@chromium.org>
Diffstat (limited to 'extra')
| -rw-r--r-- | extra/rma_reset/Makefile | 2 | ||||
| -rw-r--r-- | extra/usb_updater/Makefile | 7 |
2 files changed, 5 insertions, 4 deletions
diff --git a/extra/rma_reset/Makefile b/extra/rma_reset/Makefile index 4e401b8d5d..4a640c5b4c 100644 --- a/extra/rma_reset/Makefile +++ b/extra/rma_reset/Makefile @@ -19,7 +19,7 @@ CFLAGS := -std=gnu99 \ -Wredundant-decls \ -Wmissing-declarations -ifneq ($(DEBUG),) +ifeq ($(DEBUG),1) CFLAGS += -g -O0 else CFLAGS += -O3 diff --git a/extra/usb_updater/Makefile b/extra/usb_updater/Makefile index 8fc1c1b07a..1dfbc55645 100644 --- a/extra/usb_updater/Makefile +++ b/extra/usb_updater/Makefile @@ -19,10 +19,10 @@ CFLAGS := -std=gnu99 \ -Wredundant-decls \ -Wmissing-declarations -ifneq ($(DEBUG),) -CFLAGS += -O0 -else +ifeq (DEBUG,) CFLAGS += -O3 +else +CFLAGS += -O0 endif # @@ -52,3 +52,4 @@ clean: parser_debug: desc_parser.c gcc -g -O0 -DTEST_PARSER desc_parser.c -o dp + |