host_command: Change host command return value to enum ec_status

If the host command handler callback function returns an int, it's easy
to accidentally mix up the enum ec_error_list and enum ec_status types.
The host commands always expect an enum ec_status type, so we change the
return value to be of that explicit type. Compilation will then fail if
you accidentally try to return an enum ec_error_list value.

Ran the following commands and then manually fixed up a few remaining
instances that were not caught:

git grep --name-only 'static int .*(struct host_cmd_handler_args \*args)' |\
xargs sed -i 's#static int \(.*\)(struct host_cmd_handler_args \*args)#\
static enum ec_status \1(struct host_cmd_handler_args \*args)##'

git grep --name-only 'int .*(struct host_cmd_handler_args \*args)' |\
xargs sed -i 's#int \(.*\)(struct host_cmd_handler_args \*args)#\
enum ec_status \1(struct host_cmd_handler_args \*args)##'

BRANCH=none
BUG=chromium:1004831
TEST=make buildall -j

Cq-Depend: chrome-internal:1872675
Change-Id: Id93df9387ac53d016a1594dba86c6642babbfd1e
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816865
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>

1 files changed, 1 insertions, 1 deletions

diff --git a/extra/lightbar/simulation.h b/extra/lightbar/simulation.h
index eebd5e1f65..eb878ed04e 100644
--- a/extra/lightbar/simulation.h
+++ b/extra/lightbar/simulation.h
@@ -107,7 +107,7 @@ uint8_t *system_get_jump_tag(uint16_t tag, int *version, int *size);
 	void fake_hook_##fn(void) { fn(); }
 
 #define DECLARE_HOST_COMMAND(X, fn, Y) \
-	int fake_hostcmd_##fn(struct host_cmd_handler_args *args) \
+	enum ec_status fake_hostcmd_##fn(struct host_cmd_handler_args *args) \
 	{ return fn(args); }
 
 #define DECLARE_CONSOLE_COMMAND(X, fn, Y...) \