diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2022-07-28 09:43:22 -0500 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-08-11 20:58:59 +0000 |
| commit | c1f5a5481f1121e2f408055f04906205b779dc91 (patch) | |
| tree | 45b845932e91c87380fd864108824db379e992d0 /extra | |
| parent | 190f1cb3d5d8be5427a6853ef92edd5f166ebae8 (diff) | |
| download | chrome-ec-c1f5a5481f1121e2f408055f04906205b779dc91.tar.gz | |
apro: add new return codes
Add new ap_ro_integrity_check return codes. The existing AP_RO_PASS (2)
return code doesn't verify the GBB. Rename it to
AP_RO_PASS_UNVERIFIED_GBB. Shimless RMA should only treat
AP_RO_PASS (7) as a pass. Nothing returns this right now.
This CL also adds AP_RO_FAIL_CLEARED(8) and AP_RO_IN_PROGRESS(9).
AP_RO_IN_PROGRESS is used if AP RO verification is ongoing.
AP_RO_FAIL_CLEARED will be used in a followup CL.
old:
2 - AP_RO_PASS
new:
2 - AP_RO_PASS_UNVERIFIED_GBB
...
7 - AP_RO_PASS
8 - AP_RO_FAIL_CLEARED
9 - AP_RO_IN_PROGRESS
This saves 8 bytes since it also shortens a print message. The remaining
space changes from 5804 to 5812 bytes.
BUG=b:234497234
TEST=make buildall -j
Change-Id: I8d19a411c2534236c9defa82291872420c19a15b
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3805819
Reviewed-by: Andrey Pronin <apronin@chromium.org>
Commit-Queue: Andrey Pronin <apronin@chromium.org>
Diffstat (limited to 'extra')
| -rw-r--r-- | extra/usb_updater/gsctool.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/extra/usb_updater/gsctool.c b/extra/usb_updater/gsctool.c index 64a7853d31..747c25e17e 100644 --- a/extra/usb_updater/gsctool.c +++ b/extra/usb_updater/gsctool.c @@ -2358,6 +2358,9 @@ static int process_get_apro_boot_status(struct transfer_descriptor *td) case AP_RO_PASS: printf("pass\n"); break; + case AP_RO_PASS_UNVERIFIED_GBB: + printf("pass - unverified gbb!\n"); + break; case AP_RO_FAIL: printf("FAIL\n"); break; @@ -2370,6 +2373,15 @@ static int process_get_apro_boot_status(struct transfer_descriptor *td) case AP_RO_UNSUPPORTED_NOT_TRIGGERED: printf("not supported\ntriggered: no\n"); break; + case AP_RO_IN_PROGRESS: + printf("in progress."); + break; + case AP_RO_FAIL_CLEARED: + printf("fail CLEARED!"); + break; + case AP_RO_UNSUPPORTED_NOT_TRIGGERED: + printf("not supported\ntriggered: no\n"); + break; default: fprintf(stderr, "unknown status\n"); return update_error; |