diff options
| author | Vadim Bendebury <vbendeb@chromium.org> | 2020-05-08 17:52:10 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-29 04:42:21 +0000 |
| commit | ce4a25f69b460aca8011d21c79ad6e90e52f94df (patch) | |
| tree | 0a0310bbaaa1394f325ba29c2538e1fd413cf35b /include/ap_ro_integrity_check.h | |
| parent | 671baed12042a5c0866923427abb407818c15663 (diff) | |
| download | chrome-ec-ce4a25f69b460aca8011d21c79ad6e90e52f94df.tar.gz | |
ap RO verification: enable logging
When AP RO verification is attempted, a lot of thing could go wrong,
and the operator would usually have very little insight into what's
happening unless there is a terminal connected to the Cr50 console.
This patch adds a new log event for registering the AP RO verification
progress. The event payload is a single byte value, logging the
following events:
0 - refresh key press is detected
1 - power button has been released before AP RO check was triggered
2 - trigger sequence timeout (refresh button not pressed in time)
3 - AP RO check triggered
4 - could not run the check, hash space not programmed
5 - could not run the check, hash space corrupted
6 - AP RO verification failed
7 - AP RO verification succeeded
BUG=b:153764696
TEST=verified logging during various AP RO verification attempts:
$ gsctool -a -L
Log time zone is PST
Dec 31 69 16:00:01 : 00
May 06 20 21:20:49 : 09 01
May 06 20 21:21:53 : 09 00
May 06 20 21:21:54 : 09 00
May 06 20 21:21:55 : 09 03
May 06 20 21:21:56 : 09 07
May 06 20 21:23:03 : 09 00
May 06 20 21:23:04 : 09 00
May 06 20 21:23:05 : 09 02
May 07 20 11:21:52 : 09 00
May 07 20 11:21:53 : 09 00
May 07 20 11:21:54 : 09 01
May 08 20 11:57:21 : 09 00
May 08 20 11:57:22 : 09 00
May 08 20 11:57:23 : 09 03
May 08 20 11:57:24 : 09 04
May 08 20 12:07:15 : 09 00
May 08 20 12:07:16 : 09 00
May 08 20 12:07:17 : 09 03
May 08 20 12:07:19 : 09 07
May 08 20 12:09:20 : 09 00
May 08 20 12:09:21 : 09 00
May 08 20 12:09:22 : 09 03
May 08 20 12:09:23 : 09 06
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Change-Id: I739f9dbb2e7b8fc87601d61e1f87eb49d85bdf14
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191283
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Namyoon Woo <namyoon@chromium.org>
Diffstat (limited to 'include/ap_ro_integrity_check.h')
| -rw-r--r-- | include/ap_ro_integrity_check.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/include/ap_ro_integrity_check.h b/include/ap_ro_integrity_check.h index 365bccbe8e..0edc477c88 100644 --- a/include/ap_ro_integrity_check.h +++ b/include/ap_ro_integrity_check.h @@ -6,6 +6,8 @@ #ifndef __CR50_INCLUDE_AP_RO_INTEGRITY_CHECK_H #define __CR50_INCLUDE_AP_RO_INTEGRITY_CHECK_H +#include "flash_log.h" + /* * validate_ap_ro: based on information saved in an H1 RO flash page verify * contents of the AP flash. @@ -19,4 +21,10 @@ */ int validate_ap_ro(void); +/* + * ap_ro_add_flash_event: add a flash log event to keep track of AP RO + * verification attempt progress. + */ +void ap_ro_add_flash_event(enum ap_ro_verification_ev event); + #endif /* ! __CR50_INCLUDE_AP_RO_INTEGRITY_CHECK_H */ |