diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2021-11-24 09:00:30 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-11-29 21:44:52 +0000 |
| commit | a6b008b3aa19a48e1f769bb88e11aee1d64591f6 (patch) | |
| tree | f8da868049ccd2885845f44c342fe9eeadcb9e90 /include/ap_ro_integrity_check.h | |
| parent | 6ba72e7fd312bf9b32bb42ee0afb93082fd91885 (diff) | |
| download | chrome-ec-a6b008b3aa19a48e1f769bb88e11aee1d64591f6.tar.gz | |
ap_ro_integrity_check: call keep_ec_in_reset in do_ap_ro_checkstabilize-14385.B-cr50_stabfactory-kukui-14374.B-cr50_stab
Move the keep_ec_in_reset call into do_ap_ro_check, so AP RO
verification will hold the EC in reset when it's triggered from the AP.
This change removes the ap_ro_verification_failed_ variable, so all of
the AP RO verification is included in ap_ro_info. ap_ro_ver_state isn't
needed anymore, so this CL removes it.
BUG=b:207545621
TEST=make clobber ; make buildall -j
Change-Id: Id0b2e04b042d48f2b8a9dae021e762369ca5f3eb
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3300174
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'include/ap_ro_integrity_check.h')
| -rw-r--r-- | include/ap_ro_integrity_check.h | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/include/ap_ro_integrity_check.h b/include/ap_ro_integrity_check.h index 12d701c44b..38e4c57ff4 100644 --- a/include/ap_ro_integrity_check.h +++ b/include/ap_ro_integrity_check.h @@ -18,16 +18,9 @@ enum ap_ro_status { }; /* * validate_ap_ro: based on information saved in an H1 RO flash page verify - * contents of the AP flash. - * - * Returns: - * - * EC_SUCCESS if valid integrity check information was found and the AP flash - * check succeeded. - * EC_ERROR_INVAL in valid integrity check information was not found. - * EC_ERROR_CRC if information was found, but the AP flash check failed. + * contents of the AP flash. Hold the EC in reset if verification fails. */ -int validate_ap_ro(void); +void validate_ap_ro(void); /* * ap_ro_add_flash_event: add a flash log event to keep track of AP RO |