diff options
| author | Randall Spangler <rspangler@chromium.org> | 2012-10-02 14:12:45 -0700 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-10-02 16:05:17 -0700 |
| commit | 3c06f602b638f1f6eff1bde29dd1cbd3caf8c707 (patch) | |
| tree | 36aafe2f0351ca239df50193333f244bfb72b712 /include/battery.h | |
| parent | 2768a49fd1540cfc42652357bea6497b52042a36 (diff) | |
| download | chrome-ec-3c06f602b638f1f6eff1bde29dd1cbd3caf8c707.tar.gz | |
link: Add charge_near_full state
Tell the host the battery is no longer charging when it hits 97%, and
set the power adapter LED to green.
This solves several problems:
1) The last 3% of charge takes a looong time. Kernel/ACPI/UI already
have a hack to show the battery as charged when it's about 3% from
full, but the EC still showed a yellow LED.
2) If the system is charged and you briefly unplug the adapter, the
LED turned yellow for a long time as it slowly trickle-charged. Now
it goes right to green.
3) A fully-charged battery will drop below 100% charge as it settles,
but won't accept more current at that time. This caused the LED to
turn yellow and stay there until the battery finally settled down to
~96%, at which point it'd accept more current and top itself off. The
whole time it did this, the kernel/ACPI/UI hack from (1) would keep
reporting "battery full". Now the LED stays green too.
BUG=chrome-os-partner:11248
BRANCH=link
TEST=manual
- Discharge system to <95% full.
- Plug adapter in. LED should come on yellow.
- At around 97% full, the LED should turn green.
- Around that the UI will display "battery full".
(Note that due to rounding, the UI may take a few minutes to display
"battery full" after the LED goes green; that's ok)
- Unplug and replug adapter. LED should come on green. UI still reports
"battery full".
Change-Id: Ie56fbf3a05239e73d2c765bb98d36aa5cfedc2ef
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/34452
Diffstat (limited to 'include/battery.h')
| -rw-r--r-- | include/battery.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/battery.h b/include/battery.h index f647a29bc0..02001b763a 100644 --- a/include/battery.h +++ b/include/battery.h @@ -16,8 +16,8 @@ /* Stop charge when state of charge reaches this percentage */ #define STOP_CHARGE_THRESHOLD 100 -/* Threshold for power led to turn green */ -#define POWERLED_GREEN_THRESHOLD 90 +/* Tell host we're charged at this percentage */ +#define NEAR_FULL_THRESHOLD 97 /* Precharge only when state of charge is below this level */ #define PRE_CHARGE_THRESHOLD 25 |