diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-03-26 10:44:55 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-03-26 21:38:15 +0000 |
| commit | 9d4661b418c5d5856c86333109ab742b9695140a (patch) | |
| tree | f6f8375576bb37904c76afaa7fa6e7fb9ae4abdb /include/board_config.h | |
| parent | d63416a81bb8a978cd57e8b52275af907f4e1527 (diff) | |
| download | chrome-ec-9d4661b418c5d5856c86333109ab742b9695140a.tar.gz | |
x86: Make board_has_[before|after]_rsmrst overridable
There aren't many users of the CONFIG_* options
CONFIG_BOARD_HAS_AFTER_RSMRST or CONFIG_BOARD_HAS_BEFORE_RSMRST,
therefore this commit removes those CONFIG_* options and adds an empty
default implementation that can be overridden by boards.
BUG=b:151680590
BRANCH=None
TEST=`make -j buildall`
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I3322e5ce07de19e729ca44a736b283641029c3ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2122628
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'include/board_config.h')
| -rw-r--r-- | include/board_config.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/include/board_config.h b/include/board_config.h index 6682d8f9f4..5b21be8236 100644 --- a/include/board_config.h +++ b/include/board_config.h @@ -34,7 +34,6 @@ void board_config_pre_init(void); void board_config_post_gpio_init(void); #endif -#ifdef CONFIG_BOARD_HAS_BEFORE_RSMRST /** * Configure board before RSMRST# state change * @@ -46,19 +45,20 @@ void board_config_post_gpio_init(void); * not get interrupts in time to handle workarounds. For x86 platforms and * boards which support RSMRST# passthrough this hook will allow the board * to apply workarounds despite the PMIC sequencing. + * + * The default implementation does nothing. */ -void board_before_rsmrst(int rsmrst); -#endif +__override_proto void board_before_rsmrst(int rsmrst); -#ifdef CONFIG_BOARD_HAS_AFTER_RSMRST /** * Configure board after RSMRST# state change * * Similar to board_before_rsmrst, except this is called after passing RSMRST# * to the AP. + * + * The default implementation does nothing. */ -void board_after_rsmrst(int rsmrst); -#endif +__override_proto void board_after_rsmrst(int rsmrst); /** * Configure chip early in main(), just after board_config_pre_init(). |