diff options
author | Randall Spangler <rspangler@chromium.org> | 2017-08-23 13:18:44 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2017-08-24 11:29:02 -0700 |
commit | 1029239bc18c1a8e1bff5f7aad040cdfe421dbd2 (patch) | |
tree | 95a1275901cc5e95f7d70e6a0646c87695b3e716 /include/board_config.h | |
parent | c859c057e16c13d637326e7fae333e1d1eb80d7a (diff) | |
download | chrome-ec-1029239bc18c1a8e1bff5f7aad040cdfe421dbd2.tar.gz |
g: Move chip pre-init to chip_pre_init()
Currently, chip/g uses jtag_pre_init() to do some chip
pre-initialization that isn't actually related to JTAG. This has been
harmless, but it's currently the only chip which actually does "JTAG"
pre-init, and we'd like to get rid of that. So, move that
functionality to a new optional chip_pre_init() function.
BUG=chromium:747629
BRANCH=cr50
TEST=make buildall
boot cr50
make all dis; confirm chip_pre_init() is called early in <main>
Change-Id: I3cae0747ab0c3cc974fce9f108947207b38e035f
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/629876
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Diffstat (limited to 'include/board_config.h')
-rw-r--r-- | include/board_config.h | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/include/board_config.h b/include/board_config.h index 6742573bc2..f408db8cd6 100644 --- a/include/board_config.h +++ b/include/board_config.h @@ -1,6 +1,8 @@ /* Copyright (c) 2013 The Chromium OS Authors. All rights reserved. * Use of this source code is governed by a BSD-style license that can be * found in the LICENSE file. + * + * Extra hooks for board and chip initialization/configuration */ #ifndef __CROS_EC_BOARD_CONFIG_H @@ -48,4 +50,15 @@ void board_config_post_gpio_init(void); void board_before_rsmrst(int rsmrst); #endif +/** + * Configure chip early in main(), just after board_config_pre_init(). + * + * Most chip configuration is not particularly timing critical and can be done + * in other chip driver initialization such as system_pre_init() or HOOK_INIT + * handlers. Chip pre-init should be reserved for small amounts of critical + * functionality that can't wait that long. Think very hard before putting + * code here. + */ +void chip_pre_init(void); + #endif /* __CROS_EC_BOARD_CONFIG_H */ |