diff options
| author | Vijay Hiremath <vijay.p.hiremath@intel.com> | 2018-04-03 05:44:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-04-03 18:47:12 -0700 |
| commit | a9c7d6b0d73eaf0c48438124b40fc054183701aa (patch) | |
| tree | f921024e21f5e6efd707f0b49a8ad75c7a3bc0ee /include/chipset.h | |
| parent | 228dc8d1193d2b4c26f60a9da779803bd41fe172 (diff) | |
| download | chrome-ec-a9c7d6b0d73eaf0c48438124b40fc054183701aa.tar.gz | |
Code cleanup: Remove cold reset logic
Majority of the chipsets do not have a dedicated GPIO to trigger
AP cold reset. Current code either ignores cold reset or does a warm
reset instead or have a work around to put AP in S5 and then bring
back to S0. In order to avoid the confusion, removed the cold reset
logic and only apreset is used hence forth.
BUG=b:72426192
BRANCH=none
TEST=make buildall -j
Manually tested on GLKRVP, apreset EC command can reset AP.
Change-Id: Ie32d34f2f327ff1b61b32a4d874250dce024cf35
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/991052
Commit-Ready: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Tested-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'include/chipset.h')
| -rw-r--r-- | include/chipset.h | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/include/chipset.h b/include/chipset.h index c48eb733b8..775428ed9f 100644 --- a/include/chipset.h +++ b/include/chipset.h @@ -74,11 +74,8 @@ void chipset_force_shutdown(void); /** * Reset the CPU and/or chipset. - * - * @param cold_reset If !=0, force a cold reset of the CPU and chipset; - * if 0, just pulse the reset line to the CPU. */ -void chipset_reset(int cold_reset); +void chipset_reset(void); /** * Interrupt handler to power GPIO inputs. @@ -101,7 +98,7 @@ static inline int chipset_in_state(int state_mask) static inline void chipset_exit_hard_off(void) { } static inline void chipset_throttle_cpu(int throttle) { } static inline void chipset_force_shutdown(void) { } -static inline void chipset_reset(int cold_reset) { } +static inline void chipset_reset(void) { } static inline void power_interrupt(enum gpio_signal signal) { } static inline void chipset_handle_espi_reset_assert(void) { } static inline void chipset_handle_reboot(void) { } |