diff options
| author | CHLin <CHLIN56@nuvoton.com> | 2019-04-19 17:47:24 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-05-30 03:18:01 +0000 |
| commit | 43573d0c85fceef2fd091da1dda5f65c68f6430a (patch) | |
| tree | 8fde6baa00a5d2d68393da1c048cfe987a59438f /include/config.h | |
| parent | 4d450a6f4e86ead5255914a9d70107ceb45a4d09 (diff) | |
| download | chrome-ec-43573d0c85fceef2fd091da1dda5f65c68f6430a.tar.gz | |
npcx: disable the selection of JTAG0 signals due to strap
It was observed that pressing recovery key combination + the other
keys, some keys on the keyboard become invalid after system reboots.
(see b:129908668 for more detail.)
It is because the hardware strap pin for JTAG0 signals is
unintentionally triggered. This CL reverts the selection of JTAG signals
and set them back to keyboard scan function at system initialization.
The revert applies to all real platforms except npcx_evbs.
BRANCH=none
BUG=b:129908668
TEST=pass "make buildall"
TEST=Press the specific key combination, after the system reboots,
the keyboard function works normally. On npcx EVBs, the JTAG0 is still
functional.
Change-Id: I7ede1ea4609466fea50a97b1f60308e4cdfd4544
Signed-off-by: CHLin <CHLIN56@nuvoton.com>
Reviewed-on: https://chromium-review.googlesource.com/1575887
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: CH Lin <chlin56@nuvoton.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
(cherry picked from commit 7a87d4b5c984cc24937944b4cbcd8cd7f3b4fd0b)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1585482
Reviewed-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Commit-Queue: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
Tested-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Diffstat (limited to 'include/config.h')
| -rw-r--r-- | include/config.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/include/config.h b/include/config.h index a32f67f936..2989ee9bde 100644 --- a/include/config.h +++ b/include/config.h @@ -1644,6 +1644,15 @@ /* To define it, if I2C channel C and PECI used at the same time. */ #undef CONFIG_IT83XX_SMCLK2_ON_GPC7 +/* + * If this is not defined, the firmware will revert the JTAG selection + * triggered by the hardware strap pin. + * Un-define this flag by default for all real platforms. see (b/129908668) + * If some boards (Ex:EVB) require JTAG function, they can define it in + * their board.h + */ +#undef CONFIG_ENABLE_JTAG_SELECTION + /*****************************************************************************/ /* Keyboard config */ |