diff options
| author | Alec Berg <alecaberg@chromium.org> | 2015-01-07 12:40:24 -0800 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-01-09 05:40:18 +0000 |
| commit | 49d2682b724aa49f53344dcc2768f8ac1af41dda (patch) | |
| tree | 47979b64f10ebc20cb43c9c8b8fbeca6f260d683 /include/config.h | |
| parent | a2720a0f68bbadfabdacfad3411175733c0c4098 (diff) | |
| download | chrome-ec-49d2682b724aa49f53344dcc2768f8ac1af41dda.tar.gz | |
samus: pd: fix potential junk at end of tx transmissionstabilize-6670.B
Fix potential junk at end of PD TX transmit by adding to the DMA
transmit complete interrupt a blocking wait for SPI to finish and
then immediately disable SPI clock. This means we block in an
interrupt function for approximately 45us at the end of every
transmit. But, this is the highest priority thing going on anyway.
Note, there is still a potential for junk if both ports are
transmitting at the same time and finish very close to the same time.
BUG=chrome-os-partner:34600
BRANCH=samus
TEST=load onto samus and test communications with zinger. tested
specifically with an old zinger CL,
https://chromium-review.googlesource.com/#/c/226118/11,
which watchdogs when samus has junk at end of transmit. Tested
without this CL and verified we could never successfully flash zinger
over PD due to this watchdog and verified on scope presence of junk.
Then tested with this change and was able to successfully flash
zinger using ectool on both ports in both polarities.
Change-Id: If0cd9ab0551d36a7d7dc10232b6476dd56735972
Signed-off-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/239244
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'include/config.h')
| -rw-r--r-- | include/config.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/config.h b/include/config.h index e1ae4750d4..2270277265 100644 --- a/include/config.h +++ b/include/config.h @@ -1174,9 +1174,6 @@ /* Use comparator module for PD RX interrupt */ #define CONFIG_USB_PD_RX_COMP_IRQ -/* USB PD transmit uses SPI master */ -#undef CONFIG_USB_PD_TX_USES_SPI_MASTER - /* Support for USB type-c superspeed mux */ #undef CONFIG_USBC_SS_MUX |