diff options
author | Evan Green <evgreen@chromium.org> | 2019-08-01 11:20:14 -0700 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-10-05 00:47:41 +0000 |
commit | b63e2a87a75dce8941d087c8736c5a35544ab3b0 (patch) | |
tree | 32a4bfe24554a38c6ad30dcb38911796d2acea50 /include/console.h | |
parent | 60d66714d3b41d69942652650672fd5259815538 (diff) | |
download | chrome-ec-b63e2a87a75dce8941d087c8736c5a35544ab3b0.tar.gz |
printf: Convert %h to %ph
In order to make printf more standard, use %ph. Pass a pointer to
a struct describing the buffer, including its size. Add a convenience
macro so that conversion between the old style and new style is purely
mechanical. The old style of %h cannot be converted directly to %ph as-is
because the C standard doesn't allow flags, precision, or field width on
%p.
Ultimately the goal is to enable compile-time printf format checking.
This gets us one step closer to that.
BUG=chromium:984041
TEST=make -j buildall
BRANCH=None
Cq-Depend:chrome-internal:1559798,chrome-internal:1560598
Change-Id: I9c0ca124a048314c9b62d64bd55b36be55034e0e
Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1730605
Diffstat (limited to 'include/console.h')
-rw-r--r-- | include/console.h | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/include/console.h b/include/console.h index 73e9d9094c..dc15e5b6d3 100644 --- a/include/console.h +++ b/include/console.h @@ -10,6 +10,22 @@ #include "common.h" +/* + * The EC code base has been using %h to print a hex buffer. Encode the + * parameters to do that in a pointer to a structure that's passed as the + * printf argument. This is done rather than something like %.123ph because + * the C standard doesn't allow flags, precision, and field width on %p. + */ +struct hex_buffer_params { + const void *buffer; + uint16_t size; +}; + +#define HEX_BUF(_buffer, _size) (&(const struct hex_buffer_params){ \ + .buffer = (_buffer), \ + .size = (_size) \ +}) + #define PRINTF_TIMESTAMP_NOW NULL /* Console command; used by DECLARE_CONSOLE_COMMAND macro. */ |