printf: Convert %b to %pb

In order to turn on compile-time printf format checking,
non-standard specifiers like %b (binary) must be removed. Convert
that into %pb, which takes a pointer to a structure containing the
value to print, and how many bits to print. Use the convenience
macro BINARY_VALUE() to package these values up into a struct whose
pointer is passed to printf().

Technically this is slightly more limited functionality than we used
to support given all the possible flags, field width, and precision.
However every existing instance in our codebase was using %0NNb, where
NN is some number. If more variants are needed, the parameters structure
can be expanded in the future.

BUG=chromium:984041
TEST=make -j buildall
BRANCH=None

Change-Id: I8ef995dcf97af688fbca98ab6ff59b84092b69e3
Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1733100
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>

1 files changed, 15 insertions, 0 deletions

diff --git a/include/console.h b/include/console.h
index dc15e5b6d3..9246e92b25 100644
--- a/include/console.h
+++ b/include/console.h
@@ -26,6 +26,21 @@ struct hex_buffer_params {
 	.size = (_size) \
 })
 
+/*
+ * Define parameters to printing in binary: the value to print, and the number
+ * of digits to print.
+ */
+
+struct binary_print_params {
+	unsigned int value;
+	uint8_t count;
+};
+
+#define BINARY_VALUE(_value, _count) (&(const struct binary_print_params){ \
+	.value = (_value), \
+	.count = (_count) \
+})
+
 #define PRINTF_TIMESTAMP_NOW NULL
 
 /* Console command; used by DECLARE_CONSOLE_COMMAND macro. */