diff options
| author | Nicolas Boichat <drinkcat@chromium.org> | 2018-01-26 12:24:13 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-02-07 11:55:57 -0800 |
| commit | ad286a050ea566ebd89cb53f5118c91b04a0980c (patch) | |
| tree | e971a973353b0b2477429009d7f3804bd8d9ecec /include/ec_ec_comm_master.h | |
| parent | c8e2deb24dbbf4165acac4d3b72376d98ec210a1 (diff) | |
| download | chrome-ec-ad286a050ea566ebd89cb53f5118c91b04a0980c.tar.gz | |
charge_state_v2: Store battery information in new structures
On dual battery systems, this allows to keep both batteries
information in similar structures. This also means that battery
information can only be fetched via host commands
EC_CMD_BATTERY_GET_STATIC/DYNAMIC (next CL will make it possible
to fetch the information via shared memory/ACPI).
BRANCH=none
BUG=b:65697620
TEST=Boot lux/wand, dual-battery algorithm works, AP can fetch
both battery information via host commands.
Change-Id: I3c087e8f378c5cef0006f6bfe58335228a880e5b
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/888381
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Diffstat (limited to 'include/ec_ec_comm_master.h')
| -rw-r--r-- | include/ec_ec_comm_master.h | 19 |
1 files changed, 6 insertions, 13 deletions
diff --git a/include/ec_ec_comm_master.h b/include/ec_ec_comm_master.h index 98b8011b95..adaf564c65 100644 --- a/include/ec_ec_comm_master.h +++ b/include/ec_ec_comm_master.h @@ -11,19 +11,12 @@ #include <stdint.h> #include "config.h" -/* - * TODO(b:65697620): Move these to some other C file, depending on a config - * option. - */ -extern struct ec_response_battery_static_info base_battery_static; -extern struct ec_response_battery_dynamic_info base_battery_dynamic; - /** * Sends EC_CMD_BATTERY_GET_DYNAMIC command to slave, and writes the - * battery dynamic information into base_battery_dynamic. + * battery dynamic information into battery_dynamic[BATT_IDX_BASE]. * - * Leaves base_battery_dynamic intact on error: it is the callers responsability - * to clear the data or ignore it. + * Leaves battery_dynamic[BATT_IDX_BASE] intact on error: it is the callers + * responsibility to clear the data or ignore it. * @return EC_RES_SUCCESS on success, EC_RES_ERROR on communication error, * else forwards the error code from the slave. @@ -32,10 +25,10 @@ int ec_ec_master_base_get_dynamic_info(void); /** * Sends EC_CMD_BATTERY_GET_STATIC command to slave, and writes the - * battery static information into base_static_dynamic. + * battery static information into battery_static[BATT_IDX_BASE]. * - * Leaves base_battery_static intact on error: it is the callers responsability - * to clear the data or ignore it. + * Leaves battery_static[BATT_IDX_BASE] intact on error: it is the callers + * responsibility to clear the data or ignore it. * * @return EC_RES_SUCCESS on success, EC_RES_ERROR on communication error, * else forwards the error code from the slave. |