diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2013-05-22 12:41:08 -0500 |
|---|---|---|
| committer | ChromeBot <chrome-bot@google.com> | 2013-05-22 12:29:11 -0700 |
| commit | 3ca68b3134ae53f707a464458060d45f0a8a9ce4 (patch) | |
| tree | e7877a66ba29a6e6b79747e48d838843bd176526 /include/gpio.h | |
| parent | 93ec62ebc3ae238749915f8161a2673a7d2928d9 (diff) | |
| download | chrome-ec-3ca68b3134ae53f707a464458060d45f0a8a9ce4.tar.gz | |
haswell: fix RCIN# GPIO setting
The gpio pin used for RCIN# should be configured as open drain as the
rail is pulled up by a non-EC rail. Driving it high would leak power.
The current GPIO_HI_Z macro uses GPIO_HIGH as the default state.
However, it has been found that this actually drives the pin to ground.
It is still unclear how Link works or doesn't.
BUG=chrome-os-partner:19355
BRANCH=none
TEST=manual: boot on slippy without RCIN# causing reset and
the 'apreset warm' EC command works as expected.
Change-Id: I71425075f8d77b3d7e576a59fc24f823790e2655
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/56269
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'include/gpio.h')
| -rw-r--r-- | include/gpio.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/gpio.h b/include/gpio.h index 793b54575d..20ab664864 100644 --- a/include/gpio.h +++ b/include/gpio.h @@ -29,6 +29,7 @@ #define GPIO_OUT_LOW (GPIO_OUTPUT | GPIO_LOW) #define GPIO_OUT_HIGH (GPIO_OUTPUT | GPIO_HIGH) #define GPIO_HI_Z (GPIO_OUTPUT | GPIO_OPEN_DRAIN | GPIO_HIGH) +#define GPIO_HI_Z_OPEN (GPIO_OUTPUT | GPIO_OPEN_DRAIN | GPIO_LOW) #define GPIO_INT_EDGE (GPIO_INT_RISING | GPIO_INT_FALLING | GPIO_INT_BOTH) #define GPIO_INT_LEVEL (GPIO_INT_LOW | GPIO_INT_HIGH) #define GPIO_INT_ANY (GPIO_INT_EDGE | GPIO_INT_LEVEL) |