diff options
| author | Keith Short <keithshort@chromium.org> | 2020-03-06 09:50:58 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-03-10 19:37:00 +0000 |
| commit | 0d44674274c1b6d9bd7c3de90312982883a6e3c1 (patch) | |
| tree | 0216336834abfa9a5bed5d2a627c0898e0983984 /include/i2c.h | |
| parent | 739d2762604760e5ce24ef7be060f39f2ca5abd0 (diff) | |
| download | chrome-ec-0d44674274c1b6d9bd7c3de90312982883a6e3c1.tar.gz | |
i2c: Cleanup I2C tracing output
The output of the I2C tracing is hard to parse, especially for reads to
I2C registers. This change creates only a single I2C trace for each I2C
transfer (instead of 2 entries), and labels the write and read parts of
the I2C transaction clearly.
Example output (TCPC device during disconnect):
i2c: 1:0x20 wr 0x10 rd 0x01 0x00
i2c: 1:0x20 wr 0x10 0x01 0x00
i2c: 1:0x20 wr 0x1A rd 0x1A
i2c: 1:0x20 wr 0x1D rd 0x10
i2c: 1:0x20 wr 0x1C rd 0x70
i2c: 1:0x20 wr 0x2F 0x21
i2c: 1:0x20 wr 0x1C 0x70
i2c: 1:0x20 wr 0x2F 0x00
i2c: 1:0x20 wr 0x1C rd 0x70
i2c: 1:0x20 wr 0x1C 0x60
BUG=none
BRANCH=none
TEST=make buildall
TEST=Enable CONFIG_I2C_DEBUG and verify output.
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I077196e70ae3abb6c462cf08a3f944b43fdcf82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2091573
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'include/i2c.h')
| -rw-r--r-- | include/i2c.h | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/include/i2c.h b/include/i2c.h index b9feac13d8..3557d8e32b 100644 --- a/include/i2c.h +++ b/include/i2c.h @@ -551,17 +551,18 @@ void i2c_end_xfer_notify(const int port, /** * Defined in common/i2c_trace.c, used by i2c master to notify tracing - * funcionality of transactions. + * functionality of transactions. * * @param port: I2C port number * @param slave_addr: slave device address - * @param direction: 0 for write, - * 1 for read - * @param data: pointer to data read or written - * @param size: size of data read or written + * @param out_data: pointer to data written + * @param out_size: size of data written + * @param in_data: pointer to data read + * @param in_size: size of data read */ void i2c_trace_notify(int port, uint16_t slave_addr_flags, - int direction, const uint8_t *data, size_t size); + const uint8_t *out_data, size_t out_size, + const uint8_t *in_data, size_t in_size); /** * Set bus speed. Only support for ports with I2C_PORT_FLAG_DYNAMIC_SPEED |