summaryrefslogtreecommitdiff
path: root/include/mag_cal.h
diff options
context:
space:
mode:
authorYilun Lin <yllin@google.com>2018-09-08 00:28:07 +0800
committerchrome-bot <chrome-bot@chromium.org>2018-09-13 06:13:51 -0700
commitc857c83cca204ab23e5d355ac1751b3cd7d95fb8 (patch)
tree4bdcf1096694cb5973bdb27b17d7b2a23afb852d /include/mag_cal.h
parent25091ec77eb8bec64011cd340fb01d3b63b88446 (diff)
downloadchrome-ec-c857c83cca204ab23e5d355ac1751b3cd7d95fb8.tar.gz
type: Rename mat44_t to mat44_float_t.
Naming of many vector types and matrix types are not clear enough. For example, we have: vector_3_t, which is a vector of three int. vec3_t, which is a vector of three float. size4_t, which is a vector of four size_t. mat33_t, which is a 3x3 matrix of float. matrix_3x3_t, which is a 3x3 matrix of fixed point. Besides, we have types like int8_t, uint16_t types. To clearly distinguished types, the CL propose to, For vector types, naming should be `$type + 'v' + $num + '_t'`: vector_3_t becomes intv3_t vec3_t becomes floatv3_t vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet) For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the matrix size: matrix_3x3_t becomes mat33_fp_t # fp: fixed point mat33_t becomes mat33_float_t TEST=make buildall -j BUG=b:114662791 Change-Id: I188305fc2f4fcff6ec4343f68e1aa1d2d185f6cf Signed-off-by: Yilun Lin <yllin@google.com> Reviewed-on: https://chromium-review.googlesource.com/1215448 Commit-Ready: Yilun Lin <yllin@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'include/mag_cal.h')
-rw-r--r--include/mag_cal.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/mag_cal.h b/include/mag_cal.h
index 5e1a17531e..753052f55f 100644
--- a/include/mag_cal.h
+++ b/include/mag_cal.h
@@ -29,7 +29,7 @@ struct mag_cal_t {
* | x | y | z | 1 |
* +----+----+----+----+
*/
- mat44_t acc;
+ mat44_float_t acc;
floatv4_t acc_w;
float radius;