diff options
| author | Yilun Lin <yllin@google.com> | 2018-09-08 00:06:09 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-13 06:13:47 -0700 |
| commit | c4a842a78c778e7c15cd3f78ae354e4d21a85ae9 (patch) | |
| tree | 6668b4fd3911769f0011b5b17512d66923eea5fc /include/motion_lid.h | |
| parent | e6344f8560bad936573be75f6b2810373c2cdb01 (diff) | |
| download | chrome-ec-c4a842a78c778e7c15cd3f78ae354e4d21a85ae9.tar.gz | |
type: Rename vector_3_t to intv3_t.
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: I865aa3ecbab6cb97f8585a081a679adf00febe1d
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215442
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'include/motion_lid.h')
| -rw-r--r-- | include/motion_lid.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/motion_lid.h b/include/motion_lid.h index 155c7735c9..6ce299c0e5 100644 --- a/include/motion_lid.h +++ b/include/motion_lid.h @@ -26,7 +26,7 @@ struct accel_orientation { matrix_3x3_t rot_hinge_180; /* Vector pointing along hinge axis. */ - vector_3_t hinge_axis; + intv3_t hinge_axis; }; /* Link global structure for orientation. This must be defined in board.c. */ |