summaryrefslogtreecommitdiff
path: root/include/motion_lid.h
diff options
context:
space:
mode:
authorYilun Lin <yllin@google.com>2018-09-08 00:31:36 +0800
committerchrome-bot <chrome-bot@chromium.org>2018-09-13 06:13:51 -0700
commitcb49a07fd350d9b513b019f755730d298bf719e7 (patch)
tree49057db244ea0b103c1026e4b9aea2ce5037af1e /include/motion_lid.h
parentc857c83cca204ab23e5d355ac1751b3cd7d95fb8 (diff)
downloadchrome-ec-cb49a07fd350d9b513b019f755730d298bf719e7.tar.gz
type: Rename matrix_3x3_t to mat33_fp_t
Naming of many vector types and matrix types are not clear enough. For example, we have: vector_3_t, which is a vector of three int. vec3_t, which is a vector of three float. size4_t, which is a vector of four size_t. mat33_t, which is a 3x3 matrix of float. matrix_3x3_t, which is a 3x3 matrix of fixed point. Besides, we have types like int8_t, uint16_t types. To clearly distinguished types, the CL propose to, For vector types, naming should be `$type + 'v' + $num + '_t'`: vector_3_t becomes intv3_t vec3_t becomes floatv3_t vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet) For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the matrix size: matrix_3x3_t becomes mat33_fp_t # fp: fixed point mat33_t becomes mat33_float_t TEST=make buildall -j BUG=b:114662791 Change-Id: I51d88d44252184e4b7b3564236833b0b892edc39 Signed-off-by: Yilun Lin <yllin@google.com> Reviewed-on: https://chromium-review.googlesource.com/1215449 Commit-Ready: Yilun Lin <yllin@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'include/motion_lid.h')
-rw-r--r--include/motion_lid.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/motion_lid.h b/include/motion_lid.h
index 6ce299c0e5..110d614811 100644
--- a/include/motion_lid.h
+++ b/include/motion_lid.h
@@ -17,13 +17,13 @@
*/
struct accel_orientation {
/* Rotation matrix to rotate positive 90 degrees around the hinge. */
- matrix_3x3_t rot_hinge_90;
+ mat33_fp_t rot_hinge_90;
/*
* Rotation matrix to rotate 180 degrees around the hinge. The value
* here should be rot_hinge_90 ^ 2.
*/
- matrix_3x3_t rot_hinge_180;
+ mat33_fp_t rot_hinge_180;
/* Vector pointing along hinge axis. */
intv3_t hinge_axis;