diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2016-09-06 10:05:01 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-09-09 17:15:44 -0700 |
| commit | 31fa74cf7d6d40f55bcc54b237e4e47d39024740 (patch) | |
| tree | 30d69fdd3a953153d8011dfecb2e0146e3ae6094 /include/system.h | |
| parent | e3e330d165f6433f4694ced8851279454d9d193d (diff) | |
| download | chrome-ec-31fa74cf7d6d40f55bcc54b237e4e47d39024740.tar.gz | |
cr50: remove the pullup on sys_rst on kevin
There is leakage on SYS_RST_ODL from the internal pullup cr50 has on
DIOM0. This change removes the internal pullup on reef.
On Kevin there is a bug preventing the EC from being able to pull
sys_rst_l up high enoug for cr50 to detect that it is pulled high. This
change adds an internal pullup back when cr50 detects that it is on a
kevin or gru.
BUG=chrome-os-partner:56945
BUG=chrome-os-partner:53544
BRANCH=none
TEST=On gru and kevin remove servo verify when apreset is run on the EC
it resets cr50 and the AP. Run pinmux and check that there is a pullup
on diom0 on kevin but not on gru.
Change-Id: Ica4f557745967b93e0bd9c8462916b1f735756ac
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/381322
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'include/system.h')
| -rw-r--r-- | include/system.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/system.h b/include/system.h index 5bca2c6321..12f771df8d 100644 --- a/include/system.h +++ b/include/system.h @@ -478,6 +478,8 @@ void system_clear_retry_counter(void); #define BOARD_DISABLE_UART0_RX (1 << 3) /* Disable UART0 RX */ #define BOARD_MARK_UPDATE_ON_USB_REQ (1 << 4) /* update is good once the */ /* controller gets a request */ +/* TODO(crosbug.com/p/54059): Remove when sys_rst_l has an external pullup */ +#define BOARD_NEEDS_SYS_RST_PULL_UP (1 << 5) /* Add a pullup to sys_rst_l */ /** * Get board properites |