diff options
| author | Denis Brockus <dbrockus@chromium.org> | 2019-05-28 09:01:51 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-06-03 20:35:51 +0000 |
| commit | 9e9c24307deb302ed969b268e97cebfa4061c79c (patch) | |
| tree | e0ec7e986f0241d1b44e4a3a15d05eef61e4aa97 /include/system.h | |
| parent | 93a3f30e55e2ac5304a7cb66f24a76d51127e242 (diff) | |
| download | chrome-ec-9e9c24307deb302ed969b268e97cebfa4061c79c.tar.gz | |
common: board_[read/write]_serial weak reference cleanup
board_read_serial and board_write_serial were prototyped as weak
and this made all instances, that included that prototype, weak
as well. In order to not lose information from the prototype,
default and override functions, I changed to use the override
weak marker symbols.
These functions defaulted for specific configurations as
different functionality and used an #ifdef tree to do this. I
made these a single definition for each function and used
IS_ENABLED instead of the #ifdef tree. I also added a
definition for the case that the configuration would not have
produced a function.
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: Ie41c53f3a17d665358e46eefd3ded3066ee80a7d
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1631583
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'include/system.h')
| -rw-r--r-- | include/system.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/include/system.h b/include/system.h index e1eec86998..17419007db 100644 --- a/include/system.h +++ b/include/system.h @@ -327,13 +327,14 @@ int system_get_chip_unique_id(uint8_t **id); * Optional board-level callback functions to read a unique serial number per * chip. Default implementation reads from flash/otp (flash/otp_read_serial). */ -const char *board_read_serial(void) __attribute__((weak)); +__override_proto const char *board_read_serial(void); /** * Optional board-level callback functions to write a unique serial number per * chip. Default implementation reads from flash/otp (flash/otp_write_serial). */ -int board_write_serial(const char *serial) __attribute__((weak)); +__override_proto int board_write_serial(const char *serial); + /* * Common bbram entries. Chips don't necessarily need to implement * all of these, error will be returned from system_get/set_bbram if |