summaryrefslogtreecommitdiff
path: root/include/system.h
diff options
context:
space:
mode:
authorRandall Spangler <rspangler@chromium.org>2013-11-04 11:24:30 -0800
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2013-11-05 02:32:40 +0000
commitefb6bc76553ca8c425a3c6683fbf2790d030064e (patch)
treea7e60695e169f54e42abc592bfff53f48883c3bf /include/system.h
parent5d672b91a7f0d83e278b6f48dbd29105aabfb897 (diff)
downloadchrome-ec-efb6bc76553ca8c425a3c6683fbf2790d030064e.tar.gz
Pad jump tags to 4 bytes inside the system module
That way all the users of jump tags don't need to know about the padding requirements. BUG=chrome-os-partner:23851 BRANCH=none TEST=enable CONFIG_CMD_JUMPTAGS, then 'jumptags'. Output should be something like this: 20007fbc: 0x5550 UP.1 2 20007fc4: 0x4b42 KB.2 3 20007fcc: 0x4c50 LP.1 12 20007fdc: 0x4d54 MT.1 8 All the addresses in the first column should be word-aligned. The sizes in the last column don't need to be a multiple of 4. Change-Id: I91f9c29701a007ef8a56b5b7e0ea09930dfbea31 Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/175591 Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'include/system.h')
-rw-r--r--include/system.h5
1 files changed, 2 insertions, 3 deletions
diff --git a/include/system.h b/include/system.h
index cf936d64bf..b4c68bd3ce 100644
--- a/include/system.h
+++ b/include/system.h
@@ -109,8 +109,7 @@ int system_jumped_to_this_image(void);
* This may ONLY be called from within a HOOK_SYSJUMP handler.
*
* @param tag Data type
- * @param size Size of data; must be a multiple of 4 bytes, and less
- * than 255 bytes.
+ * @param size Size of data; must be less than 255 bytes.
* @param version Data version, so that tag data can evolve as firmware
* is updated.
* @param data Pointer to data to save
@@ -128,7 +127,7 @@ int system_add_jump_tag(uint16_t tag, int version, int size, const void *data);
* @param version Set to data version if successful
* @param size Set to data size if successful
* @return A pointer to the data, or NULL if no matching tag is
- * found.
+ * found. This pointer will be 32-bit aligned.
*/
const uint8_t *system_get_jump_tag(uint16_t tag, int *version, int *size);